From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Patrick Boettcher <pboettcher@kernellabs.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PULL] request for 2.6.38-rc1
Date: Sun, 16 Jan 2011 13:06:44 -0200 [thread overview]
Message-ID: <4D330984.2010307@infradead.org> (raw)
In-Reply-To: <alpine.LRH.2.00.1101141542460.6649@pub3.ifh.de>
Em 14-01-2011 12:51, Patrick Boettcher escreveu:
> Hi Mauro,
>
> if it is not too late, here is a pull request for some new devices from DiBcom. It would be nice to have it in 2.6.38-rc1.
>
> Pull from
>
> git://linuxtv.org/pb/media_tree.git staging/for_2.6.38-rc1.dibcom
>
> for
>
> DiBxxxx: Codingstype updates
Not sure if this is by purpose, but you're changing all
msleep(10) into msleep(20). This sounds very weird for a
CodingStyle fix:
- msleep(10);
+ msleep(20);
> DiB0700: add support for several board-layouts
Hmm...
+ if (request_firmware(&state->frontend_firmware, "dib9090.fw", &adap->dev->udev->dev)) {
Where's dib9090.fw firmware is available? The better is to submit a patch to linux-firmware
with the firmware binary, with some license that allows end-users to use it with your device
and distros/distro partners to re-distribute it. While here, please add also the other
dibcom firmwares.
Vendors are free to use their own legal text for it. There are several examples for it
at:
http://git.kernel.org/?p=linux/kernel/git/dwmw2/linux-firmware.git;a=blob_plain;f=WHENCE;hb=HEAD
Btw, there are two alignment errors (one at dib7000p, for some cases, aligned with 4 chars),
and another at dib8000, where all statements after an if are aligned with 3 tabs plus one space.
I'm fixing those issues, c/c you at the fix patches.
Cheers,
Mauro
next prev parent reply other threads:[~2011-01-16 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 14:51 [PULL] request for 2.6.38-rc1 Patrick Boettcher
2011-01-16 15:06 ` Mauro Carvalho Chehab [this message]
2011-01-19 11:34 ` Patrick Boettcher
2011-01-19 13:19 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D330984.2010307@infradead.org \
--to=mchehab@infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=pboettcher@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.