From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59808 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PenUa-00033l-NX
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 06:43:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PenUZ-0006YP-DD
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 06:43:24 -0500
Received: from mel.act-europe.fr ([194.98.77.210]:36032)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PenUZ-0006Xc-95
	for qemu-devel@nongnu.org; Mon, 17 Jan 2011 06:43:23 -0500
Message-ID: <4D342B4A.5040900@adacore.com>
Date: Mon, 17 Jan 2011 12:43:06 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 1/6] Emulation of GRLIB GPTimer as defined
	in GRLIB IP Core User's Manual.
References: <cover.1294055704.git.chouteau@adacore.com>
	<db09857decbff34801c34922dd97154a39dbaea4.1294055704.git.chouteau@adacore.com>
	<AANLkTi=hwv4y0mOf9W_YOLo9=jXAOjOTpvVtZ1CMKQM7@mail.gmail.com>
In-Reply-To: <AANLkTi=hwv4y0mOf9W_YOLo9=jXAOjOTpvVtZ1CMKQM7@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 01/04/2011 07:46 PM, Blue Swirl wrote:
> On Mon, Jan 3, 2011 at 2:07 PM, Fabien Chouteau<chouteau@adacore.com>  wrote:+}
>> +static uint32_t grlib_gptimer_readl(void *opaque, target_phys_addr_t addr)
>> +{
>> +    GPTimerUnit *unit  = opaque;
>> +    uint32_t     value = 0;
>> +
>> +    addr&= 0xff;
>
> Not needed.
>

When io-memory starts at 0x8000300 and its size is 48 bytes, Qemu gives me
address like this one (for example):

0x320

But only the last two bytes of the address are significant, that's why I use
this bit-mask.

Maybe I do not initialize io-memory in a proper way...

-- 
Fabien Chouteau