diff for duplicates of <4D343680.1030701@ru.mvista.com> diff --git a/a/1.txt b/N1/1.txt index 168b95f..e49748f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -12,17 +12,17 @@ On 17-01-2011 13:08, Vasiliy Kulikov wrote: > --- a/arch/arm/mach-omap2/smartreflex.c > +++ b/arch/arm/mach-omap2/smartreflex.c > @@ -260,7 +260,10 @@ static int sr_late_init(struct omap_sr *sr_info) -> if (sr_class->class_type = SR_CLASS2&& +> if (sr_class->class_type == SR_CLASS2&& > sr_class->notify_flags&& sr_info->irq) { > > + ret = -ENOMEM; > name = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL); -> + if (name = NULL) +> + if (name == NULL) > + goto error; Why not: - if (name = NULL) { + if (name == NULL) { ret = -ENOMEM; goto error; } diff --git a/a/content_digest b/N1/content_digest index 60acda9..f0b1e8e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,14 @@ "ref\01295258922-31242-1-git-send-email-segoon@openwall.com\0" "From\0Sergei Shtylyov <sshtylyov@mvista.com>\0" "Subject\0Re: [PATCH] arm: mach-omap2: potential NULL dereference\0" - "Date\0Mon, 17 Jan 2011 12:30:56 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Mon, 17 Jan 2011 15:30:56 +0300\0" + "To\0Vasiliy Kulikov <segoon@openwall.com>\0" + "Cc\0kernel-janitors@vger.kernel.org" + Tony Lindgren <tony@atomide.com> + linux-omap@vger.kernel.org + Russell King <linux@arm.linux.org.uk> + linux-kernel@vger.kernel.org + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hello.\n" @@ -19,21 +25,21 @@ "> --- a/arch/arm/mach-omap2/smartreflex.c\n" "> +++ b/arch/arm/mach-omap2/smartreflex.c\n" "> @@ -260,7 +260,10 @@ static int sr_late_init(struct omap_sr *sr_info)\n" - "> \tif (sr_class->class_type = SR_CLASS2&&\n" + "> \tif (sr_class->class_type == SR_CLASS2&&\n" "> \t\tsr_class->notify_flags&& sr_info->irq) {\n" ">\n" "> +\t\tret = -ENOMEM;\n" "> \t\tname = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL);\n" - "> +\t\tif (name = NULL)\n" + "> +\t\tif (name == NULL)\n" "> +\t\t\tgoto error;\n" "\n" " Why not:\n" "\n" - "\t\tif (name = NULL) {\n" + "\t\tif (name == NULL) {\n" "\t\t\tret = -ENOMEM;\n" "\t\t\tgoto error;\n" "\t\t}\n" "\n" WBR, Sergei -ed2fe1dd4a637d8e5d6153c53f36df3a6cae1570e4479d91675c43eeeac2a5f9 +3de1c302cd1f0265ea94eef98b20547578c38c85f7c00e96e8f19dabc547a88f
diff --git a/a/1.txt b/N2/1.txt index 168b95f..e49748f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -12,17 +12,17 @@ On 17-01-2011 13:08, Vasiliy Kulikov wrote: > --- a/arch/arm/mach-omap2/smartreflex.c > +++ b/arch/arm/mach-omap2/smartreflex.c > @@ -260,7 +260,10 @@ static int sr_late_init(struct omap_sr *sr_info) -> if (sr_class->class_type = SR_CLASS2&& +> if (sr_class->class_type == SR_CLASS2&& > sr_class->notify_flags&& sr_info->irq) { > > + ret = -ENOMEM; > name = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL); -> + if (name = NULL) +> + if (name == NULL) > + goto error; Why not: - if (name = NULL) { + if (name == NULL) { ret = -ENOMEM; goto error; } diff --git a/a/content_digest b/N2/content_digest index 60acda9..7c1f7a9 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,7 +1,7 @@ "ref\01295258922-31242-1-git-send-email-segoon@openwall.com\0" - "From\0Sergei Shtylyov <sshtylyov@mvista.com>\0" - "Subject\0Re: [PATCH] arm: mach-omap2: potential NULL dereference\0" - "Date\0Mon, 17 Jan 2011 12:30:56 +0000\0" + "From\0sshtylyov@mvista.com (Sergei Shtylyov)\0" + "Subject\0[PATCH] arm: mach-omap2: potential NULL dereference\0" + "Date\0Mon, 17 Jan 2011 15:30:56 +0300\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -19,21 +19,21 @@ "> --- a/arch/arm/mach-omap2/smartreflex.c\n" "> +++ b/arch/arm/mach-omap2/smartreflex.c\n" "> @@ -260,7 +260,10 @@ static int sr_late_init(struct omap_sr *sr_info)\n" - "> \tif (sr_class->class_type = SR_CLASS2&&\n" + "> \tif (sr_class->class_type == SR_CLASS2&&\n" "> \t\tsr_class->notify_flags&& sr_info->irq) {\n" ">\n" "> +\t\tret = -ENOMEM;\n" "> \t\tname = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL);\n" - "> +\t\tif (name = NULL)\n" + "> +\t\tif (name == NULL)\n" "> +\t\t\tgoto error;\n" "\n" " Why not:\n" "\n" - "\t\tif (name = NULL) {\n" + "\t\tif (name == NULL) {\n" "\t\t\tret = -ENOMEM;\n" "\t\t\tgoto error;\n" "\t\t}\n" "\n" WBR, Sergei -ed2fe1dd4a637d8e5d6153c53f36df3a6cae1570e4479d91675c43eeeac2a5f9 +d0de5a33016aa6bbdfec923b208758c44245c07e66df6f0667e61fe4b15d22f4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.