From: Anthony Liguori <anthony@codemonkey.ws>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] RFC: mass comment conversion from C99 to C89
Date: Mon, 17 Jan 2011 09:04:48 -0600 [thread overview]
Message-ID: <4D345A90.3030409@codemonkey.ws> (raw)
In-Reply-To: <AANLkTinn-ddCtoga+UHFvfCH3arssDkc9q+hqX35v-s3@mail.gmail.com>
On 01/16/2011 06:12 PM, Peter Maydell wrote:
> On 15 January 2011 16:02, Blue Swirl<blauwirbel@gmail.com> wrote:
>
>> With the sed script below (my first I think), I'm able to convert most
>> files in QEMU from C99 comment style to C89. When successive line with
>> C99 comments are converted, the comments are merged. Two files
>> (hw/rtl8139.c and microblaze-dis.c) still fail.
>>
>> Is this a good idea?
>>
> I'm a bit wary of this kind of wide-scale no-semantic-change commit
> (and more so for things like indent, brace and whitespace fixes
> which can affect large chunks of actual code), because it makes
> it harder to deal with qemu forks (especially if you were hoping to
> be able to periodically rebase with an eye to eventually getting
> changes back into mainline qemu).
>
Yeah, I'm equally wary of such changes unless they have a very clear
value (e.g. changing an API definition to accommodate an extra parameter).
Regards,
Anthony Liguori
> This particular changeset doesn't touch target-arm so
> it doesn't affect me personally, though.
>
> -- PMM
>
>
next prev parent reply other threads:[~2011-01-17 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 16:02 [Qemu-devel] RFC: mass comment conversion from C99 to C89 Blue Swirl
2011-01-15 17:20 ` Laurent Vivier
2011-01-15 17:27 ` Blue Swirl
2011-01-15 17:44 ` Stefan Weil
2011-01-15 18:01 ` Blue Swirl
2011-01-17 0:12 ` Peter Maydell
2011-01-17 15:04 ` Anthony Liguori [this message]
2011-01-17 20:17 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D345A90.3030409@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.