Re: [PATCH v14 1/2] davinci vpbe: platform specific additions

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

Hadli, Manjunath wrote:

>>> This patch implements the overall device creation for the Video 
>>> display driver.

>>     It does not only that...

>>> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
>>> Acked-by: Muralidharan Karicheri<m-karicheri2@ti.com>
>>> Acked-by: Hans Verkuil<hverkuil@xs4all.nl>
>> [...]

>>> diff --git a/arch/arm/mach-davinci/devices.c 
>>> b/arch/arm/mach-davinci/devices.c index 22ebc64..f435c7d 100644
>>> --- a/arch/arm/mach-davinci/devices.c
>>> +++ b/arch/arm/mach-davinci/devices.c
>>> @@ -33,6 +33,8 @@
>>>   #define DM365_MMCSD0_BASE	     0x01D11000
>>>   #define DM365_MMCSD1_BASE	     0x01D00000
>>>
>>> +void __iomem  *davinci_sysmodbase;
>>> +

>>     I think this should be added in a sperate patch.

    I meant to type "separate". :-)

>>> diff --git a/arch/arm/mach-davinci/include/mach/dm644x.h 
>>> b/arch/arm/mach-davinci/include/mach/dm644x.h
>>> index 5a1b26d..790925f 100644
>>> --- a/arch/arm/mach-davinci/include/mach/dm644x.h
>>> +++ b/arch/arm/mach-davinci/include/mach/dm644x.h
>>> @@ -40,8 +44,14 @@
>>>   #define DM644X_ASYNC_EMIF_DATA_CE2_BASE 0x06000000
>>>   #define DM644X_ASYNC_EMIF_DATA_CE3_BASE 0x08000000
>>>
>>> +/* VPBE register base addresses */
>>> +#define DM644X_VPSS_REG_BASE		0x01c73400
>>> +#define DM644X_VENC_REG_BASE		0x01C72400
>>> +#define DM644X_OSD_REG_BASE		0x01C72600

>>     Note that for other devices we don't have '_REG' in such macros. Would make sense to delete it here for consistency.

> You mean other devices like Dm355/Dm365?

    No, I mean macros defining the base addresses of the other SoC devices (like 
EMAC and AEMIF you have just above your macros).

WBR, Sergei