From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Franck Bui-Huu <fbuihuu@gmail.com>,
linux-kernel@vger.kernel.org, 2nddept-manager@sdl.hitachi.co.jp,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH -perf/perf/core 4/6] perf: Add strfilter for general purpose string filter
Date: Tue, 18 Jan 2011 01:39:39 +0900 [thread overview]
Message-ID: <4D3470CB.6000408@hitachi.com> (raw)
In-Reply-To: <20110117125534.GD3902@ghostprotocols.net>
(2011/01/17 21:55), Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 17, 2011 at 10:40:29AM -0200, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, Jan 13, 2011 at 09:46:17PM +0900, Masami Hiramatsu escreveu:
>>> Add strfilter for general purpose string filter.
>>> Every filter rules are descrived by glob matching pattern
>>> and '!' prefix which means Logical NOT.
>>> A strfilter consists of those filter rules connected
>>> with '&' and '|'. A set of rules can be folded by using
>>> '(' and ')'. It also accepts spaces around rules and those
>>
>> You're not checking strfilter__alloc results, I'm fixing this for you
>> this time :-)
>
> Not really, please check strdup() result and strfilter__delete() needs
> to traverse all the nodes, not just the ones pointed at the root, right?
Would you mean that it should release all the node including
ascendants? Hmm, I think we might just need to update its parent
so that it doesn't get affected, because the strfilter__delete()
doesn't know which user variable points the parent of the given node.
E.g. If we remove "b*" from "(a* | b*)", just update it as "(a* | !*)"
> Please address these problems and resubmit this patch, I merged the
> first three, folding the documentation one you sent for --funcs into the
> third, where the feature was added.
>
> Please rebase from my perf/core branch at:
>
> http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=shortlog;h=refs/heads/perf/core
>
Yeah, anyway, I'll update it for fixing the misses you pointed.
Thanks!
> - Arnaldo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2011-01-17 16:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 12:45 [PATCH -perf/perf/core 0/6] Perf probe update (support inline call-site/--funcs/--filter) Masami Hiramatsu
2011-01-13 12:45 ` [PATCH -perf/perf/core 1/6] perf probe: Introduce lines walker interface Masami Hiramatsu
2011-01-26 7:22 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2011-01-13 12:46 ` [PATCH -perf/perf/core 2/6] perf probe: Enable to put probe inline function call site Masami Hiramatsu
2011-01-26 7:22 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2011-01-13 12:46 ` [PATCH -perf/perf/core 3/6] perf probe: Add --funcs to show available functions in symtab Masami Hiramatsu
2011-01-13 21:24 ` Franck Bui-Huu
2011-01-14 9:49 ` Masami Hiramatsu
2011-01-14 9:53 ` [PATCH -perf/perf/core ] perf probe: Update perf-probe.txt for --funcs Masami Hiramatsu
2011-01-15 16:42 ` Arnaldo Carvalho de Melo
2011-01-26 7:23 ` [tip:perf/core] perf probe: Add --funcs to show available functions in symtab tip-bot for Masami Hiramatsu
2011-01-13 12:46 ` [PATCH -perf/perf/core 4/6] perf: Add strfilter for general purpose string filter Masami Hiramatsu
2011-01-13 13:01 ` Peter Zijlstra
2011-01-13 13:18 ` Masami Hiramatsu
2011-01-17 12:40 ` Arnaldo Carvalho de Melo
2011-01-17 12:55 ` Arnaldo Carvalho de Melo
2011-01-17 16:39 ` Masami Hiramatsu [this message]
2011-01-18 13:45 ` Masami Hiramatsu
2011-01-13 12:46 ` [PATCH -perf/perf/core 5/6] perf probe: Add variable filter support Masami Hiramatsu
2011-01-13 21:18 ` Franck Bui-Huu
2011-01-14 2:42 ` Masami Hiramatsu
2011-01-17 12:07 ` Arnaldo Carvalho de Melo
2011-01-19 1:12 ` Masami Hiramatsu
2011-01-13 12:46 ` [PATCH -perf/perf/core 6/6] perf probe: Add filters support for available functions Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3470CB.6000408@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=2nddept-manager@sdl.hitachi.co.jp \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fbuihuu@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.