All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Chou <thomas@wytron.com.tw>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] nios2: reset cfi flash before reading env
Date: Tue, 18 Jan 2011 10:05:51 +0800	[thread overview]
Message-ID: <4D34F57F.5040406@wytron.com.tw> (raw)
In-Reply-To: <20110117210220.CB2EDD1CAD5@gemini.denx.de>

Dear Wolfgang,

On 01/18/2011 05:02 AM, Wolfgang Denk wrote:
>> void __flash_cmd_reset(flash_info_t *info)
>
> I recommend you have a second, closer look. Notice that
> flash_cmd_reset() comes with __attribute__ weak, because it does not
> work as a general solution - it may work here, but other code may be
> needed on other flash chips.
>
> Your code does not provide such an option.

Thanks a lot. I will add a weak attribute.

Best regards,
Thomas

  reply	other threads:[~2011-01-18  2:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05  7:17 [U-Boot] [PATCH] nios2: reset cfi flash before reading env Thomas Chou
2011-01-05  8:15 ` Wolfgang Denk
2011-01-06  2:36   ` Thomas Chou
2011-01-17 21:02     ` Wolfgang Denk
2011-01-18  2:05       ` Thomas Chou [this message]
2011-01-18  3:13       ` [U-Boot] [PATCH v2] " Thomas Chou
2011-03-26 14:47         ` Scott McNutt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D34F57F.5040406@wytron.com.tw \
    --to=thomas@wytron.com.tw \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.