From: Mark Hatle <mark.hatle@windriver.com>
To: Nitin A Kamble <nitin.a.kamble@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 10/12] dates: fix build issue with gcc dso linking change
Date: Mon, 17 Jan 2011 21:39:29 -0600 [thread overview]
Message-ID: <4D350B71.2010306@windriver.com> (raw)
In-Reply-To: <77d22ac6e219167f0611a2136326979a96f634c4.1295304080.git.nitin.a.kamble@intel.com>
On 1/17/11 4:45 PM, Nitin A Kamble wrote:
> All the libraries needs to be specified explicitely with the new gcc dso
> linking change patch. This was causing build errors for this
> recipe. Specifying the libm and libpango-1.0 libraries explicitely for
> linking to work without errors.
>
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
...
> +Nitin A Kamble <nitin.a.kamble@intel.com>
> +Date: 2011/01/11
> +
> +Index: git/src/Makefile.am
> +===================================================================
> +--- git.orig/src/Makefile.am
> ++++ git/src/Makefile.am
> +@@ -34,6 +34,6 @@ dates_SOURCES = $(platform) \
> + gconf-bridge.h \
> + gconf-bridge.c
> +
> +-dates_LDADD = $(DATES_LIBS) $(OWL_LIBS) libgtkdatesview.la
> ++dates_LDADD = $(DATES_LIBS) $(OWL_LIBS) libgtkdatesview.la -lm -lpango-1.0
Only concern I have with this patch is that, at first glance it looks like there
might be a problem with the libgtkdatesview.la or one of the existing $(...)
items causing the missing dependency.
I'd like to make sure that the .la files have been inspected and verify they do
not require libm or libpango. Assuming they do not, could you add a comment to
the patch indicating that's been checked so when the next person looks they
won't be confused by whats going on.
--Mark
> +
> + MAINTAINERCLEANFILES = config.h.in Makefile.in
> diff --git a/meta/recipes-sato/pimlico/dates_git.bb b/meta/recipes-sato/pimlico/dates_git.bb
> index bceeec6..973c42d 100644
> --- a/meta/recipes-sato/pimlico/dates_git.bb
> +++ b/meta/recipes-sato/pimlico/dates_git.bb
> @@ -6,9 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> file://src/gconf-bridge.c;endline=22;md5=ad7626c6daf4aec590474a243f4912fa"
>
> PV = "0.4.11+git${SRCPV}"
> -PR = "r2"
> +PR = "r3"
>
> S = "${WORKDIR}/git"
>
> SRC_URI = "git://git.gnome.org/${PN};protocol=git \
> - file://make-382.patch"
> + file://make-382.patch \
> + file://dso_linking_change_build_fix.patch"
next prev parent reply other threads:[~2011-01-18 3:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 22:45 [PATCH 00/12] gcc dso linking change, and related fixes Nitin A Kamble
2011-01-17 22:45 ` [PATCH 01/12] gcc_4.5.1: add DSO linking change patch Nitin A Kamble
2011-01-17 22:45 ` [PATCH 03/12] libmusicbrainz: fix the build failure caused by gcc dso linkcing change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 02/12] sat-solver: " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 06/12] matchbox-desktop: fix build issue with gcc dso linking change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 05/12] settings-daemon: fix build error with new " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 07/12] xtscal: fix build issue with " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 04/12] oprofileui: fix the build failure after gcc dso change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 12/12] screenshot: fix build issue with gcc dso linking change Nitin A Kamble
2011-01-18 3:40 ` Mark Hatle
2011-01-18 4:16 ` Kamble, Nitin A
2011-01-19 0:38 ` Kamble, Nitin A
2011-01-17 22:45 ` [PATCH 10/12] dates: " Nitin A Kamble
2011-01-18 3:39 ` Mark Hatle [this message]
2011-01-18 4:14 ` Kamble, Nitin A
2011-01-17 22:45 ` [PATCH 11/12] matchbox-stroke: : " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 08/12] blktrace: " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 09/12] fstests: " Nitin A Kamble
2011-01-21 0:13 ` [PATCH 00/12] gcc dso linking change, and related fixes Richard Purdie
2011-01-21 16:39 ` Kamble, Nitin A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D350B71.2010306@windriver.com \
--to=mark.hatle@windriver.com \
--cc=nitin.a.kamble@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.