From: Kristoffer Glembo <kristoffer@gaisler.com>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH 2/4 V2] sparc: Add pci32_unmap_page.
Date: Tue, 18 Jan 2011 09:15:38 +0000 [thread overview]
Message-ID: <4D355A3A.5030003@gaisler.com> (raw)
In-Reply-To: <1294909535-6290-3-git-send-email-kristoffer@gaisler.com>
Hi Sam,
Sorry for my sluggish replies.
Sam Ravnborg wrote:
> On Thu, Jan 13, 2011 at 10:05:33AM +0100, Kristoffer Glembo wrote:
>> Signed-off-by: Kristoffer Glembo <kristoffer@gaisler.com>
>
> I totally miss _why_ you add this function.
> Just a small comment in the changelog would help.
> It may due to my ignorance of all the dma stuff...
>
It is part of the DMA API and needed by our ethernet driver. I guess no PCI driver (on sparc) used it before.
>
> How about a patch that fix it so mmu_inval_dma_area() takes a void *
> as first argument?
> In most cases I see a cast from void * => unsigned long where we call
> mmu_inval_dma_area().
>
Ok.
/Kristoffer
prev parent reply other threads:[~2011-01-18 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 9:05 [PATCH 2/4 V2] sparc: Add pci32_unmap_page Kristoffer Glembo
2011-01-13 9:50 ` Sam Ravnborg
2011-01-18 9:15 ` Kristoffer Glembo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D355A3A.5030003@gaisler.com \
--to=kristoffer@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.