From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support Date: Tue, 18 Jan 2011 14:27:20 +0300 Message-ID: <4D357918.4040001@ru.mvista.com> References: <1295248259-14752-1-git-send-email-B33228@freescale.com> <4D342C6E.6000608@ru.mvista.com> <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:65484 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745Ab1ARL2a (ORCPT ); Tue, 18 Jan 2011 06:28:30 -0500 Received: by ewy5 with SMTP id 5so3169095ewy.19 for ; Tue, 18 Jan 2011 03:28:28 -0800 (PST) In-Reply-To: <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Zang Roy-R61911 Cc: Sergei Shtylyov , Xu Lei-B33228 , "linuxppc-dev@lists.ozlabs.org" , Gala Kumar-B11780 , "jgarzik@pobox.com" , "linux-ide@vger.kernel.org" Hello. On 18-01-2011 6:01, Zang Roy-R61911 wrote: >>> In FSL sata v2 block, the snoop bit of PRDT Word3 description >>> information is at bit28 instead of bit22. >>> This patch adds FSL sata v2 probe and resolve this difference. >>> Signed-off-by: Xulei > [snip] >>> diff --git a/arch/powerpc/boot/dts/p1022ds.dts >> b/arch/powerpc/boot/dts/p1022ds.dts >>> index 2bbecbb..9ad41dd 100644 >>> --- a/arch/powerpc/boot/dts/p1022ds.dts >>> +++ b/arch/powerpc/boot/dts/p1022ds.dts >>> @@ -475,14 +475,14 @@ >>> }; >>> >>> sata@18000 { >>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata"; >>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2"; >>> reg =<0x18000 0x1000>; >>> cell-index =<1>; >>> interrupts =<74 0x2>; >>> }; >>> >>> sata@19000 { >>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata"; >>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2"; >>> reg =<0x19000 0x1000>; >>> cell-index =<2>; >>> interrupts =<41 0x2>; >> Please put this into the separate patch and push thru the PPC tree. > I agree to put to them to separate patches, but should we > pull in the separate patches to one candidate tree to make > the function work? I don't understand. What is "candidate tree"? > Thanks. > Roy WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ew0-f51.google.com (mail-ew0-f51.google.com [209.85.215.51]) by ozlabs.org (Postfix) with ESMTP id 82201B70EA for ; Tue, 18 Jan 2011 22:28:32 +1100 (EST) Received: by ewy19 with SMTP id 19so3039249ewy.38 for ; Tue, 18 Jan 2011 03:28:28 -0800 (PST) Message-ID: <4D357918.4040001@ru.mvista.com> Date: Tue, 18 Jan 2011 14:27:20 +0300 From: Sergei Shtylyov MIME-Version: 1.0 To: Zang Roy-R61911 Subject: Re: [PATCH] ATA: Add FSL sata v2 controller support References: <1295248259-14752-1-git-send-email-B33228@freescale.com> <4D342C6E.6000608@ru.mvista.com> <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net> In-Reply-To: <2239AC579C7D3646A720227A37E0268109001B@039-SN1MPN1-004.039d.mgd.msft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Xu Lei-B33228 , Sergei Shtylyov , "jgarzik@pobox.com" , "linux-ide@vger.kernel.org" , Gala Kumar-B11780 , "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hello. On 18-01-2011 6:01, Zang Roy-R61911 wrote: >>> In FSL sata v2 block, the snoop bit of PRDT Word3 description >>> information is at bit28 instead of bit22. >>> This patch adds FSL sata v2 probe and resolve this difference. >>> Signed-off-by: Xulei > [snip] >>> diff --git a/arch/powerpc/boot/dts/p1022ds.dts >> b/arch/powerpc/boot/dts/p1022ds.dts >>> index 2bbecbb..9ad41dd 100644 >>> --- a/arch/powerpc/boot/dts/p1022ds.dts >>> +++ b/arch/powerpc/boot/dts/p1022ds.dts >>> @@ -475,14 +475,14 @@ >>> }; >>> >>> sata@18000 { >>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata"; >>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2"; >>> reg =<0x18000 0x1000>; >>> cell-index =<1>; >>> interrupts =<74 0x2>; >>> }; >>> >>> sata@19000 { >>> - compatible = "fsl,mpc8536-sata", "fsl,pq-sata"; >>> + compatible = "fsl,p1022-sata", "fsl,pq-sata-v2"; >>> reg =<0x19000 0x1000>; >>> cell-index =<2>; >>> interrupts =<41 0x2>; >> Please put this into the separate patch and push thru the PPC tree. > I agree to put to them to separate patches, but should we > pull in the separate patches to one candidate tree to make > the function work? I don't understand. What is "candidate tree"? > Thanks. > Roy WBR, Sergei