All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Freyther <zecke@selfish.org>
To: linux-sctp@vger.kernel.org
Subject: [PATCH] sctp: Remove store to ret as it is not used
Date: Tue, 18 Jan 2011 11:32:11 +0000	[thread overview]
Message-ID: <4D357A3B.3000606@selfish.org> (raw)

The store to ret is not needed. In case it is 0 the method
will be exited directly, if not ret will be assigned again
and then returned to the caller.

Signed-off-by: Holger Hans Peter Freyther <zecke@selfish.org>
Acked-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
 net/sctp/socket.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index e47e39e..86ce53d 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -393,9 +393,8 @@ SCTP_STATIC int sctp_do_bind(struct sock *sk, union
sctp_addr *addr, int len)
 	 * detection.
 	 */
 	addr->v4.sin_port = htons(snum);
-	if ((ret = sctp_get_port_local(sk, addr))) {
+	if (sctp_get_port_local(sk, addr))
 		return -EADDRINUSE;
-	}
  	/* Refresh ephemeral port.  */
 	if (!bp->port)
-- 
1.7.3.4


             reply	other threads:[~2011-01-18 11:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 11:32 Holger Freyther [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-23 10:56 [PATCH] sctp: Remove store to ret as it is not used Holger Freyther
2011-03-23 10:56 ` Holger Freyther

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D357A3B.3000606@selfish.org \
    --to=zecke@selfish.org \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.