All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, "Justin M. Forbes" <jforbes@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit
Date: Tue, 18 Jan 2011 12:39:57 +0100	[thread overview]
Message-ID: <4D357C0D.5070802@redhat.com> (raw)
In-Reply-To: <1295345442-16218-2-git-send-email-stefanha@linux.vnet.ibm.com>

Am 18.01.2011 11:10, schrieb Stefan Hajnoczi:
> Provide the "removable" qdev property bit to override the SCSI INQUIRY
> removable (RMB) bit for non-CDROM devices.  This will be used by USB
> Mass Storage Devices, which sometimes have this guest-visible bit set
> and sometimes do not.  They therefore requires a means for user
> configuration.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Should we print an error message when the user tries to make a CD-ROM
non-removable instead of silently ignoring the option?

Kevin

  reply	other threads:[~2011-01-18 11:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 10:10 [Qemu-devel] [PATCH v2 0/3] usb-msd: Add usb-storage, removable=on|off property Stefan Hajnoczi
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 1/3] scsi-disk: Allow overriding SCSI INQUIRY removable bit Stefan Hajnoczi
2011-01-18 11:39   ` Kevin Wolf [this message]
2011-01-18 12:06     ` Stefan Hajnoczi
2011-01-21 10:45       ` Stefan Hajnoczi
2011-01-21 11:09         ` Kevin Wolf
2011-01-21 17:38           ` Markus Armbruster
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 2/3] scsi: Allow SCSI devices to override the " Stefan Hajnoczi
2011-01-18 10:10 ` [Qemu-devel] [PATCH v2 3/3] usb-msd: Propagate removable bit to SCSI device Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D357C0D.5070802@redhat.com \
    --to=kwolf@redhat.com \
    --cc=hch@lst.de \
    --cc=jforbes@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.