From: Patrick McHardy <kaber@trash.net>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jan Engelhardt <jengelh@medozas.de>,
Tim Waugh <twaugh@redhat.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack snmp helper
Date: Tue, 18 Jan 2011 14:45:34 +0100 [thread overview]
Message-ID: <4D35997E.6060502@trash.net> (raw)
In-Reply-To: <20110117094547.GA1918@jolsa.brq.redhat.com>
On 17.01.2011 10:45, Jiri Olsa wrote:
> hi,
> thanks for comments, attaching new patch
> --- a/net/netfilter/Makefile
> +++ b/net/netfilter/Makefile
> @@ -28,7 +28,8 @@ obj-$(CONFIG_NF_CONNTRACK_AMANDA) += nf_conntrack_amanda.o
> obj-$(CONFIG_NF_CONNTRACK_FTP) += nf_conntrack_ftp.o
> obj-$(CONFIG_NF_CONNTRACK_H323) += nf_conntrack_h323.o
> obj-$(CONFIG_NF_CONNTRACK_IRC) += nf_conntrack_irc.o
> -obj-$(CONFIG_NF_CONNTRACK_NETBIOS_NS) += nf_conntrack_netbios_ns.o
> +obj-$(CONFIG_NF_CONNTRACK_NETBIOS_NS) += nf_conntrack_netbios_ns.o nf_conntrack_broadcast.o
> +obj-$(CONFIG_NF_CONNTRACK_SNMP) += nf_conntrack_snmp.o nf_conntrack_broadcast.o
Just add an EXPORT_SYMBOL_GPL'ed function and a new Kconfig
symbol for the nf_conntrack_broadcast.o file that is selected
by NETBIOS_NS and SNMP.
> obj-$(CONFIG_NF_CONNTRACK_PPTP) += nf_conntrack_pptp.o
> obj-$(CONFIG_NF_CONNTRACK_SANE) += nf_conntrack_sane.o
> obj-$(CONFIG_NF_CONNTRACK_SIP) += nf_conntrack_sip.o
> diff --git a/net/netfilter/nf_conntrack_broadcast.c b/net/netfilter/nf_conntrack_broadcast.c
> new file mode 100644
> index 0000000..fb48be1
> --- /dev/null
> +++ b/net/netfilter/nf_conntrack_broadcast.c
> @@ -0,0 +1,79 @@
> +/*
> + * broadcast connection tracking helper
> + *
> + * (c) 2011 Jiri Olsa <jolsa@redhat.com>
I'd also prefer if you keep my copyright statement from
the netbios ns file.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version
> + * 2 of the License, or (at your option) any later version.
> + */
next prev parent reply other threads:[~2011-01-18 13:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 20:18 [RFC,PATCH] netfilter: SNMP conntrack module Jiri Olsa
2011-01-14 21:18 ` Jan Engelhardt
2011-01-15 16:15 ` Patrick McHardy
2011-01-17 9:45 ` [PATCH] netfilter: nf_conntrack snmp helper Jiri Olsa
2011-01-18 13:45 ` Patrick McHardy [this message]
2011-01-18 16:37 ` [PATCHv2] " Jiri Olsa
2011-01-18 17:14 ` Patrick McHardy
2011-01-18 17:21 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35997E.6060502@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=jolsa@redhat.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=twaugh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.