From: Patrick McHardy <kaber@trash.net>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
Tim Gardner <tim.gardner@canonical.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH resend] netfilter: change IPS_*_BIT to IPS_*
Date: Tue, 18 Jan 2011 15:05:51 +0100 [thread overview]
Message-ID: <4D359E3F.4040804@trash.net> (raw)
In-Reply-To: <1295090445-14431-1-git-send-email-xiaosuo@gmail.com>
On 15.01.2011 12:20, Changli Gao wrote:
> My previous patch made a mistake when converting atomic_set to a normal
> bit 'or'. IPS_*_BIT should be replaced with IPS_*.
Then please state this clearly in the subject instead of calling it
a resend. Also we use "netfilter: <subsystem>: <change description>",
as I've told you multiple times already.
>
> commit 76a2d3bcfcc86e2a8044258515b86492a37631a3
> Author: Changli Gao <xiaosuo@gmail.com>
> Date: Mon Nov 15 11:59:03 2010 +0100
>
> netfilter: nf_nat: don't use atomic bit operation
>
> As we own the conntrack and the others can't see it until we confirm it,
> we don't need to use atomic bit operation on ct->status.
Applied, thanks.
prev parent reply other threads:[~2011-01-18 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 11:20 [PATCH resend] netfilter: change IPS_*_BIT to IPS_* Changli Gao
2011-01-18 14:05 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D359E3F.4040804@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tim.gardner@canonical.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.