From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH v2] mac80211: drop non-auth 3-addr data frames when running as a 4-addr station
Date: Tue, 18 Jan 2011 16:02:53 +0100 [thread overview]
Message-ID: <4D35AB9D.6040004@openwrt.org> (raw)
In-Reply-To: <1295362547.3563.22.camel@jlt3.sipsolutions.net>
On 2011-01-18 3:55 PM, Johannes Berg wrote:
> On Tue, 2011-01-18 at 15:48 +0100, Felix Fietkau wrote:
>> When running as a 4-addr station against an AP that has the 4-addr VLAN
>> interface and the main 3-addr AP interface bridged together, sometimes
>> frames originating from the station were looping back from the 3-addr AP
>> interface, causing the bridge code to emit warnings about receiving frames
>> with its own source address.
>> I'm not sure why this is happening yet, but I think it's a good idea to
>> drop all frames (except 802.1x/EAP frames) that do not match the configured
>> addressing mode, including 4-address frames sent to a 3-address station.
>> User test reports indicate that the problem goes away with this patch.
>
> This looks better, thanks. But did they really test _this_ patch? :)
A few users tested this and told me that it didn't make things worse
compared to my first patch - which did fix some, but not all issues
related to this.
- Felix
prev parent reply other threads:[~2011-01-18 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 14:48 [PATCH v2] mac80211: drop non-auth 3-addr data frames when running as a 4-addr station Felix Fietkau
2011-01-18 14:55 ` Johannes Berg
2011-01-18 15:02 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35AB9D.6040004@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.