From: Mark Hatle <mark.hatle@windriver.com>
To: poky <poky@yoctoproject.org>
Subject: [PATCH 1/1] sanity.bbclass: Disable TERMCMD checking with noop patching
Date: Tue, 18 Jan 2011 10:21:04 -0600 [thread overview]
Message-ID: <4D35BDF0.5030507@windriver.com> (raw)
In-Reply-To: <4D35BD84.6010201@windriver.com>
If PATCHRESOLVE is set to "noop", then it isn't supposed to try and
resolve patches at all, and thus does not need TERMCMD. Therefore,
make sure Poky doesn't check for (and possibly fail at finding)
TERMCMD if it isn't needed in the first place.
Signed-off-by: Derek Buitenhuis <dbuitenh@windriver.com>
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
---
meta/classes/sanity.bbclass | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 315fc34..ccf40fb 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -189,11 +189,12 @@ def check_sanity(e):
if not data.getVar( 'DISPLAY', e.data, True ) and data.getVar( 'IMAGETEST',
e.data, True ) == 'qemu':
messages = messages + 'qemuimagetest needs a X desktop to start qemu,
please set DISPLAY correctly (e.g. DISPLAY=:1.0)\n'
- # Ensure we have the binary for TERMCMD, as when patch application fails
the error is fairly intimidating
- termcmd = data.getVar("TERMCMD", e.data, True)
- term = termcmd.split()[0]
- if not check_app_exists(term, e.data):
- messages = messages + "The console for use in patch error resolution is
not available, please install %s or set TERMCMD and TERMCMDRUN$
+ if data.getVar('PATCHRESOLVE', e.data, True) != 'noop':
+ # Ensure we have the binary for TERMCMD, as when patch application
fails the error is fairly intimidating
+ termcmd = data.getVar("TERMCMD", e.data, True)
+ term = termcmd.split()[0]
+ if not check_app_exists(term, e.data):
+ messages = messages + "The console for use in patch error
resolution is not available, please install %s or set TERMCMD and TERMC$
if os.path.basename(os.readlink('/bin/sh')) == 'dash':
messages = messages + "Using dash as /bin/sh causes various subtle
build problems, please use bash instead (e.g. 'dpkg-reconfigure da$
--
1.7.3.4
next prev parent reply other threads:[~2011-01-18 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 16:19 [PATCH 0/1] Update santiy.bbclass when patch resolution "noop" Mark Hatle
2011-01-18 16:21 ` Mark Hatle [this message]
2011-01-20 23:29 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35BDF0.5030507@windriver.com \
--to=mark.hatle@windriver.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.