From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45881 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfEmL-0008VJ-8l
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:52:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PfElf-0000RG-I0
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:51:33 -0500
Received: from mail-qw0-f45.google.com ([209.85.216.45]:64631)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PfElf-0000R3-FO
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 11:50:51 -0500
Received: by qwk4 with SMTP id 4so6183261qwk.4
	for <qemu-devel@nongnu.org>; Tue, 18 Jan 2011 08:50:50 -0800 (PST)
Message-ID: <4D35C4E7.4080704@codemonkey.ws>
Date: Tue, 18 Jan 2011 10:50:47 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/2] strtosz(): Use suffix macros in switch()
	statement
References: <1295284345-24524-1-git-send-email-Jes.Sorensen@redhat.com>	<1295284345-24524-3-git-send-email-Jes.Sorensen@redhat.com>
	<m3r5cain49.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3r5cain49.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, Jes.Sorensen@redhat.com, Alex.Williamson@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On 01/18/2011 03:20 AM, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
>
>    
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>> ---
>>   cutils.c |   10 +++++-----
>>   1 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/cutils.c b/cutils.c
>> index 328738c..f2c8bbd 100644
>> --- a/cutils.c
>> +++ b/cutils.c
>> @@ -324,26 +324,26 @@ ssize_t strtosz_suffix(const char *nptr, char **end, const char default_suffix)
>>           }
>>       }
>>       switch (toupper(d)) {
>> -    case 'B':
>> +    case STRTOSZ_DEFSUFFIX_B:
>>           mul = 1;
>>           if (mul_required) {
>>               goto fail;
>>           }
>>           break;
>> -    case 'K':
>> +    case STRTOSZ_DEFSUFFIX_KB:
>>           mul = 1<<  10;
>>           break;
>>       case 0:
>>           if (mul_required) {
>>               goto fail;
>>           }
>> -    case 'M':
>> +    case STRTOSZ_DEFSUFFIX_MB:
>>           mul = 1ULL<<  20;
>>           break;
>> -    case 'G':
>> +    case STRTOSZ_DEFSUFFIX_GB:
>>           mul = 1ULL<<  30;
>>           break;
>> -    case 'T':
>> +    case STRTOSZ_DEFSUFFIX_TB:
>>           mul = 1ULL<<  40;
>>           break;
>>       default:
>>      
> And this improves what?  Certainly not clarity.
>
> In my opinion, the STRTOSZ_DEFSUFFIX_TB are useless chaff.  Chacun à son
> goût.
>    

Yeah, I have to agree.  I'm not of the literals are evil camp.

BTW, a useful change would be to accept both upper and lower case letters.

Regards,

Anthony Liguori