From: Alexander Holler <holler@ahsoftware.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] ARM: print gcc version
Date: Tue, 18 Jan 2011 18:04:54 +0100 [thread overview]
Message-ID: <4D35C836.3020400@ahsoftware.de> (raw)
In-Reply-To: <1295367620.29642.10984.camel@petert>
Am 18.01.2011 17:20, schrieb Peter Tyser:
>>>> Anyway, I would found it a nice feature, at startup or when running the
>>>> version command, but both aren't a must.
>>>
>>> I think it would be a really useful extension to the version command.
>>> Looking forwad to seeing your patch.
>>
>> Maybe if someone could feed me with what to use for the version. E.g. my
>> gcc here defines __VERSION__ as "4.5.2" but when I'm looking at
>> u-boot/lib/asm-offsets.s I see
>>
>> .ident "GCC: (Gentoo 4.5.2 p1.0, pie-0.4.5) 4.5.2"
>>
>> So I would like to display that which would be in line with the comment
>> section of generated binaries.
>>
>> But when I use "gcc -E -dM empty.c" to print all predefined macros, I
>> don't see the text found in .ident. Not even something else which
>> includes "Gentoo".
>
> I believe the output of "$(CC) --version" should contain the same data
> as your .ident string. You could echo it into a file like:
> diff --git a/Makefile b/Makefile
> index 0685ef9..e070d40 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -416,6 +416,8 @@ $(U_BOOT_ONENAND): $(ONENAND_IPL) $(obj)u-boot.bin
> $(VERSION_FILE):
> @( printf '#define U_BOOT_VERSION "U-Boot %s%s"\n' "$(U_BOOT_VERSION)" \
> '$(shell $(TOPDIR)/tools/setlocalversion $(TOPDIR))' )> $@.tmp
> + @( printf '#define CC_VERSION_STRING "%s"\n' \
> + '$(shell $(CC) --version | head -1)' )>> $@.tmp
> @cmp -s $@ $@.tmp&& rm -f $@.tmp || mv -f $@.tmp $@
>
> $(TIMESTAMP_FILE):
That would the trick. The first line of gcc --version includes here the
correct string. Thanks. (Btw. I would use head -n 1)
But I will wait for a comment from one of the maintainers about defining
CC_VERSION_STRING.
If someone gives me an ok, I will write a patch including your
suggestion and will print that version in the command version.
Regards,
Alexander
next prev parent reply other threads:[~2011-01-18 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 16:38 [U-Boot] [RFC PATCH] ARM: print gcc version Alexander Holler
2011-01-09 21:03 ` Wolfgang Denk
2011-01-11 2:00 ` Alexander Holler
2011-01-17 22:28 ` Wolfgang Denk
2011-01-18 9:16 ` Alexander Holler
2011-01-18 16:20 ` Peter Tyser
2011-01-18 17:04 ` Alexander Holler [this message]
2011-01-18 19:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D35C836.3020400@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.