From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: "Igor M. Liplianin" <liplianin@me.by>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9 v2] Altera FPGA based CI driver module.
Date: Tue, 18 Jan 2011 20:16:25 -0200 [thread overview]
Message-ID: <4D361139.7080101@infradead.org> (raw)
In-Reply-To: <201101182123.31987.liplianin@me.by>
Em 18-01-2011 17:23, Igor M. Liplianin escreveu:
> В сообщении от 16 января 2011 19:52:38 автор Mauro Carvalho Chehab написал:
>> Em 02-01-2011 10:01, Igor M. Liplianin escreveu:
>>> An Altera FPGA CI module for NetUP Dual DVB-T/C RF CI card.
>>>
>>> Signed-off-by: Igor M. Liplianin <liplianin@netup.ru>
>>
>> Igor,
>>
>> There's something wrong with this patch. I got lots of error after applying
>> it:
>>
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_read_attribute_mem':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:304:
>> multiple definition of `netup_ci_read_attribute_mem'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:241: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function `netup_ci_op_cam':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:269:
>> multiple definition of `netup_ci_op_cam'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:171: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_slot_shutdown':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:364:
>> multiple definition of `netup_ci_slot_shutdown'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:293: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_slot_ts_ctl':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:370:
>> multiple definition of `netup_ci_slot_ts_ctl'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:320: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_write_cam_ctl':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:322:
>> multiple definition of `netup_ci_write_cam_ctl'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:259: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_read_cam_ctl':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:315:
>> multiple definition of `netup_ci_read_cam_ctl'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:252: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_write_attribute_mem':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:310:
>> multiple definition of `netup_ci_write_attribute_mem'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:247: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_poll_ci_slot_status':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:448:
>> multiple definition of `netup_poll_ci_slot_status'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:403: first defined here
>> drivers/media/video/cx23885/altera-ci.o: In function
>> `netup_ci_slot_reset':
>> /home/v4l/v4l/patchwork/drivers/media/video/cx23885/altera-ci.c:327:
>> multiple definition of `netup_ci_slot_reset'
>> drivers/media/video/cx23885/cx23885.o:/home/v4l/v4l/patchwork/drivers/medi
>> a/video/cx23885/cimax2.c:264: first defined here
>>
>>
>> Please fix it and submit a new version. The better is to replace all those
>> new symbols to start with altera_ci.
> I see, allyesconfig...
Yes.
>>
>> While here, please, on the first patch, move the Altera FPGA driver to
>> staging, to give people some time do discuss about it.
> It means that cx23885 driver will depend on staging. Is it OK?
The idea is to enable the Altera-dependent part of cx23885 only if compiled.
There's no need to make the entire cx2388x dependent of Altera driver.
>
>>
>> PS.: there are a few CodingStyle errors on this patch. Please always review
>> your patches with ./scripts/checkpatch.pl.
> I'll do it.
Ok, thanks!
>>
>> Thanks!
>> Mauro
>
prev parent reply other threads:[~2011-01-18 22:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 12:01 [PATCH 2/9 v2] Altera FPGA based CI driver module Igor M. Liplianin
2011-01-16 17:52 ` Mauro Carvalho Chehab
2011-01-18 19:23 ` Igor M. Liplianin
2011-01-18 22:16 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D361139.7080101@infradead.org \
--to=mchehab@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.