From: Jeff Garzik <jgarzik@pobox.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...)
Date: Tue, 18 Jan 2011 19:56:10 -0500 [thread overview]
Message-ID: <4D3636AA.2000402@pobox.com> (raw)
In-Reply-To: <201101102134.28111.sshtylyov@ru.mvista.com>
On 01/10/2011 01:34 PM, Sergei Shtylyov wrote:
> ... in hpt_dma_blacklisted().
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree plus the patches queued by
> Jeff Garzik in his 'upstream-linus' branch.
>
> Changes from the previous version:
> - added the similar change for the 'pata_hpt37x' driver...
>
> drivers/ata/pata_hpt366.c | 6 +++---
> drivers/ata/pata_hpt37x.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-2.6/drivers/ata/pata_hpt366.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_hpt366.c
> +++ linux-2.6/drivers/ata/pata_hpt366.c
> @@ -25,7 +25,7 @@
> #include<linux/libata.h>
>
> #define DRV_NAME "pata_hpt366"
> -#define DRV_VERSION "0.6.9"
> +#define DRV_VERSION "0.6.10"
>
> struct hpt_clock {
> u8 xfer_mode;
> @@ -160,8 +160,8 @@ static int hpt_dma_blacklisted(const str
>
> while (list[i] != NULL) {
> if (!strcmp(list[i], model_num)) {
> - printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
> - modestr, list[i]);
> + pr_warning(DRV_NAME ": %s is not supported for %s.\n",
> + modestr, list[i]);
> return 1;
> }
> i++;
> Index: linux-2.6/drivers/ata/pata_hpt37x.c
> ===================================================================
> --- linux-2.6.orig/drivers/ata/pata_hpt37x.c
> +++ linux-2.6/drivers/ata/pata_hpt37x.c
> @@ -24,7 +24,7 @@
> #include<linux/libata.h>
>
> #define DRV_NAME "pata_hpt37x"
> -#define DRV_VERSION "0.6.18"
> +#define DRV_VERSION "0.6.19"
>
> struct hpt_clock {
> u8 xfer_speed;
> @@ -229,8 +229,8 @@ static int hpt_dma_blacklisted(const str
>
> while (list[i] != NULL) {
> if (!strcmp(list[i], model_num)) {
> - printk(KERN_WARNING DRV_NAME ": %s is not supported for %s.\n",
> - modestr, list[i]);
> + pr_warning(DRV_NAME ": %s is not supported for %s.\n",
> + modestr, list[i]);
Even though I am applying these patches -- forward progress -- I would
encourage you to consider ata_dev_printk() here, since we have the
ata_device pointer available.
prev parent reply other threads:[~2011-01-19 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 18:34 [PATCH 1/2 v3] pata_hpt{366|37x}: use pr_warning(...) instead of printk(KERN_WARNING ...) Sergei Shtylyov
2011-01-19 0:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3636AA.2000402@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.