All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuzmichev <vkuzmichev@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] NetRxPackets
Date: Wed, 19 Jan 2011 11:14:05 +0300	[thread overview]
Message-ID: <4D369D4D.20506@mvista.com> (raw)
In-Reply-To: <201101190027.28425.korgull@home.nl>

Hi Marcel,

Marcel wrote:
>> Not sure that branch is anything up to date....
>
> hmmm.  What branch is best to work on for this code ?

If someone sends USB-CDC patches they usually are applied into master
branch of u-boot-usb.git repository:
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot/u-boot-usb.git;a=summary

AFAIK, master branch of u-boot main repository is also working well, but
I haven't checked whether all recent patches are pulled into main
repository.
If you are using another version of u-boot (one of the previous
releases) the driver in your version may be broken.

According to the log from "Usage of DMA" thread I think your gadget
stack is up to date.

>>>>> req->buf = (u8 *) NetRxPackets[0];
>>
>> *maybe* "req" itself is not allocated?
> 
> Good question. My code that rejects the buffer is this :
> 
> [...]
>         if (!_req || !_req->complete
>                         || !_req->buf || !list_empty(&req->queue)) {
>           
>                 DBG("invalid request\n");
>                 if(!_req) debug("NO REQUEST\n");
>                 if(!_req->complete) debug("NO REQUEST COMPLETE\n");
>                 if(!_req->buf) debug("NO REQUEST BUF\n");
>                 if(!list_empty(&req->queue)) debug("NO LIST EMPTY\n");
>                 return -EINVAL;
>         }
> 
> It just keeps failing with "NO REQUEST BUF". I feel like I'm staring at a typo 
> for days and just don't see it.

I suppose that usage of kzalloc in usba_ep_alloc_request (if you haven't
changed it) may be not well. at91_udc driver (for example) uses static
pool for requests allocation.

Anyway it's strange. I have a suspicion that buf was set to NULL
somewhere inside atmel_usba_udc.


____
With best regards,
Vitaly.

      reply	other threads:[~2011-01-19  8:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18  0:15 [U-Boot] {Spam?} NetRxPackets Marcel
2011-01-18 21:08 ` [U-Boot] NetRxPackets Marcel
2011-01-18 21:28   ` Wolfgang Denk
2011-01-18 22:37     ` Marcel
2011-01-18 22:53       ` Wolfgang Denk
2011-01-18 23:41         ` Marcel
2011-01-18 22:54       ` Reinhard Meyer
2011-01-18 23:27         ` Marcel
2011-01-19  8:14           ` Vitaly Kuzmichev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D369D4D.20506@mvista.com \
    --to=vkuzmichev@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.