All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shubhrajyoti <shubhrajyoti@ti.com>
To: shubhrajyoti@ti.com
Cc: linux-iio@vger.kernel.org, greg@kroah.com,
	Shubhrajyoti D <a0393217@india.ti.com>
Subject: Re: [PATCH] hmc5843: Trivial optimisation
Date: Wed, 19 Jan 2011 15:35:51 +0530	[thread overview]
Message-ID: <4D36B77F.1060709@ti.com> (raw)
In-Reply-To: <1295431372-20951-1-git-send-email-shubhrajyoti@ti.com>

On Wednesday 19 January 2011 03:32 PM, shubhrajyoti@ti.com wrote:
> From: Shubhrajyoti D<a0393217@india.ti.com>.
Some how the email addresses got messed up. Please ignore this patch.
> Free the memory that is used only at init
>
> Signed-off-by: Shubhrajyoti Datta<shubhrajyoti@ti.com>
> Acked-by: "Jonathan Cameron<jic23@cam.ac.uk>"
> ---
>   drivers/staging/iio/magnetometer/hmc5843.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c
> index 4f4c98a..a93c0fb 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.c
> +++ b/drivers/staging/iio/magnetometer/hmc5843.c
> @@ -516,7 +516,7 @@ static int hmc5843_detect(struct i2c_client *client,
>   }
>
>   /* Called when we have found a new HMC5843. */
> -static void hmc5843_init_client(struct i2c_client *client)
> +static void __devinit hmc5843_init_client(struct i2c_client *client)
>   {
>   	struct hmc5843_data *data = i2c_get_clientdata(client);
>   	hmc5843_set_meas_conf(client, data->meas_conf);
> @@ -527,7 +527,7 @@ static void hmc5843_init_client(struct i2c_client *client)
>   	pr_info("HMC5843 initialized\n");
>   }
>
> -static int hmc5843_probe(struct i2c_client *client,
> +static int __devinit hmc5843_probe(struct i2c_client *client,
>   			 const struct i2c_device_id *id)
>   {
>   	struct hmc5843_data *data;
> @@ -572,7 +572,7 @@ exit:
>   	return err;
>   }
>
> -static int hmc5843_remove(struct i2c_client *client)
> +static int __devexit hmc5843_remove(struct i2c_client *client)
>   {
>   	struct hmc5843_data *data = i2c_get_clientdata(client);
>   	 /*  sleep mode to save power */
> @@ -614,7 +614,7 @@ static struct i2c_driver hmc5843_driver = {
>   	},
>   	.id_table	= hmc5843_id,
>   	.probe		= hmc5843_probe,
> -	.remove		= hmc5843_remove,
> +	.remove		=  __devexit_p(hmc5843_remove),
>   	.detect		= hmc5843_detect,
>   	.address_list	= normal_i2c,
>   };


  reply	other threads:[~2011-01-19 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19 10:02 [PATCH] hmc5843: Trivial optimisation shubhrajyoti
2011-01-19 10:05 ` Shubhrajyoti [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-01-19 10:04 shubhrajyoti
2011-01-18  6:59 [PATCH ]hmc5843: Convert to dev pm ops shubhrajyoti
2011-01-18  6:59 ` [PATCH ] hmc5843: Trivial optimisation shubhrajyoti
2011-01-18 11:14   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D36B77F.1060709@ti.com \
    --to=shubhrajyoti@ti.com \
    --cc=a0393217@india.ti.com \
    --cc=greg@kroah.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.