From: Hans de Bruin <jmdebruin@xmsnet.nl>
To: Jesse Gross <jesse@nicira.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: fix can_checksum_protocol() arguments swap
Date: Wed, 19 Jan 2011 16:01:15 +0100 [thread overview]
Message-ID: <4D36FCBB.2060309@xmsnet.nl> (raw)
In-Reply-To: <AANLkTi=sJGFPNkzG9sDDjiREsRXVj8U_rWNr6sWvhX-e@mail.gmail.com>
On 01/19/2011 02:33 PM, Jesse Gross wrote:
> On Wed, Jan 19, 2011 at 2:51 AM, Eric Dumazet<eric.dumazet@gmail.com> wrote:
>> commit 0363466866d901fbc (net offloading: Convert checksums to use
>> centrally computed features.) mistakenly swapped can_checksum_protocol()
>> arguments.
>>
>> This broke IPv6 on bnx2 for instance, on NIC without TCPv6 checksum
>> offloads.
>>
>> Reported-by: Hans de Bruin<jmdebruin@xmsnet.nl>
>> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com>
>> CC: Jesse Gross<jesse@nicira.com>
>> ---
>> I cant believe I spent so much time on this bug.
>
> Thanks Eric, I was staring at this code and I can't believe that I
> didn't see it.
>
> Acked-by: Jesse Gross<jesse@nicira.com>
I have applied the patch and the ipv6 connectivity is back.
--
Hans
next prev parent reply other threads:[~2011-01-19 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 10:51 [PATCH] net: fix can_checksum_protocol() arguments swap Eric Dumazet
2011-01-19 13:33 ` Jesse Gross
2011-01-19 15:01 ` Hans de Bruin [this message]
2011-01-19 22:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D36FCBB.2060309@xmsnet.nl \
--to=jmdebruin@xmsnet.nl \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.