From: Boaz Harrosh <bharrosh@panasas.com>
To: David Dillow <dillowda@ornl.gov>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jeff Moyer <jmoyer@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v3] fs/direct-io.c: don't try to allocate more than BIO_MAX_PAGES in a bio
Date: Wed, 19 Jan 2011 17:53:38 +0200 [thread overview]
Message-ID: <4D370902.2020501@panasas.com> (raw)
In-Reply-To: <1295404470.5233.31.camel@obelisk.thedillows.org>
On 01/19/2011 04:34 AM, David Dillow wrote:
> On Tue, 2011-01-18 at 16:53 -0800, Andrew Morton wrote:
>>
>> Well. -stable only needs the patch if the driver which triggers the
>> problem is also there. But we don't know what driver that is, yet???
>
> Good point.
>
> Any driver that supports a sg_tablesize of more than 256 has the
> potential for problems. A quick search of the tree indicates that the
> following set their initial sg_tablesize to SCSI_MAX_SG_CHAIN_SEGMENTS
> (2048), though they may be saved by a separate bug I found -- and sent a
> patch to the list -- that incorrectly causes that define to take the
> value 128.
>
> ./drivers/usb/storage/scsiglue.c
> ./drivers/scsi/arm/powertec.c
> ./drivers/scsi/arm/eesox.c
> ./drivers/scsi/arm/cumana_2.c
> ./drivers/ata/pata_icside.c
>
<snip>
iscsi has it on 2048 since ever
Boaz
prev parent reply other threads:[~2011-01-19 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 4:05 fs/direct-io.c: don't try to allocate more than BIO_MAX_PAGES in a bio David Dillow
2011-01-14 14:44 ` Jeff Moyer
2011-01-14 16:46 ` [PATCH v2 alt 1] " David Dillow
2011-01-14 16:46 ` [PATCH v2 alt 2] " David Dillow
2011-01-17 18:28 ` Jeff Moyer
2011-01-18 3:00 ` [PATCH v3] " David Dillow
2011-01-19 0:53 ` Andrew Morton
2011-01-19 2:34 ` David Dillow
2011-01-19 15:53 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D370902.2020501@panasas.com \
--to=bharrosh@panasas.com \
--cc=akpm@linux-foundation.org \
--cc=dillowda@ornl.gov \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.