From: Ciju Rajan K <ciju@linux.vnet.ibm.com>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
lkml <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Ciju Rajan K <ciju@linux.vnet.ibm.com>
Subject: Re: [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat
Date: Wed, 19 Jan 2011 21:25:54 +0530 [thread overview]
Message-ID: <4D37098A.8010706@linux.vnet.ibm.com> (raw)
In-Reply-To: <4D3687C1.4000909@jp.fujitsu.com>
>>
>> This patch set removes only those fields which are currently not in use.
>> If you observe the fields of /proc/schedstat the following fields are not
>> being updated.
>
> Ah... I misunderstood the meaning of `unused' and complained based on too
> old kernel's source. Sorry.>
> I confirmed that these fields are actually not treated by upstream kernel
> at all. So I think it's OK if any userland tools are updated synchronized
> with this change.
Thanks for verifying it.
Does its benefit is more than its cost? In my
> understanding, its benefit is improving readability and reducing some memory
> footprint, and its cost is changing all userspace tools referring /proc/schedstat.
In my opinion we should go ahead with updating /proc/schedstat.
As I mentioned earlier, we can have an updated script for
http://eaglet.rain.com/rick/linux/schedstat/
>
> # Unfortunately I don't know how much it costs.
The changes required in the userspace would be very small.
Its just a matter of re-ordering the values. I also can't think
of much complicated scenario than this.
-Ciju
>
prev parent reply other threads:[~2011-01-19 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 10:49 [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat Ciju Rajan K
2011-01-17 10:52 ` [PATCH 1/2 v1.0]sched: Removing unused fields from /proc/schedstat Ciju Rajan K
2011-01-17 10:54 ` [PATCH 2/2 v1.0]sched: Updating the sched-stat documentation Ciju Rajan K
2011-01-17 16:54 ` [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat Peter Zijlstra
2011-01-18 6:01 ` Ciju Rajan K
2011-01-18 6:04 ` [PATCH 1/2 v1.0]sched: Removing unused fields from /proc/schedstat Ciju Rajan K
2011-01-18 6:04 ` [PATCH 2/2 v1.0]sched: Updating the sched-stat documentation Ciju Rajan K
2011-01-19 7:11 ` Satoru Takeuchi
2011-01-19 15:47 ` Ciju Rajan K
2011-01-18 7:29 ` [RFC][PATCH 0/2 v1.0]sched: updating /proc/schedstat Satoru Takeuchi
2011-01-18 7:50 ` Ciju Rajan K
2011-01-19 6:42 ` Satoru Takeuchi
2011-01-19 15:55 ` Ciju Rajan K [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D37098A.8010706@linux.vnet.ibm.com \
--to=ciju@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bharata@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.