Re: [offline-atoms PATCH 1/2] Make gprs atom offline-safe.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

Hi Pekka,

On 01/19/2011 07:33 AM, Pekka Pessi wrote:
> Hi Denis,
> 
> 2011/1/19 Denis Kenzior <denkenz@gmail.com>:
>>> +     if (gprs->netreg == NULL) {
>>> +             gprs_netreg_removed(gprs);
>>> +             return;
>>> +     }
>>> +
>>
>> I'm having trouble visualizing why this chunk is necessary.  We reset
>> netreg to NULL only when shutting down the atom or when netreg atom goes
>> away.  So this condition should never be triggered.
> 
> It is for the case where the gprs atom is inserted in post_sim but
> netreg in post_online.
> 

I still don't see it, applying your patch and removing this chunk works
just fine.  I can set Powered / Roaming Allowed with no issues...

Regards,
-Denis