From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "Tero.Kristo@nokia.com" <Tero.Kristo@nokia.com>,
"Sripathy, Vishwanath" <vishwanath.bs@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"paul@pwsan.com" <paul@pwsan.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>
Subject: Re: [PATCH] OMAP3: CPUIdle: prevent CORE from going off if doing so would reset an active clockdomain
Date: Wed, 19 Jan 2011 14:25:09 -0600 [thread overview]
Message-ID: <4D3748A5.4020207@ti.com> (raw)
In-Reply-To: <91467096ca191cde5a0d8b69ef0fce00@mail.gmail.com>
On 1/19/2011 3:03 AM, Shilimkar, Santosh wrote:
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
>> owner@vger.kernel.org] On Behalf Of Tero.Kristo@nokia.com
>> Sent: Wednesday, January 19, 2011 2:09 PM
>> To: vishwanath.bs@ti.com; linux-omap@vger.kernel.org
>> Cc: paul@pwsan.com; khilman@deeprootsystems.com
>> Subject: RE: [PATCH] OMAP3: CPUIdle: prevent CORE from going off if
>> doing so would reset an active clockdomain
>>
> [...]
>
>>>> If some parts of the chip are busy, then how can Core domain
>> enter off
>>>> state? The necessary condition for Core to enter low power state
>> is
>>> that
>>>> all the clock domains (including DSS, CAM, IVA, USB, PER etc)
>> should
>>>> have
>>>> idled. Doesn't it mean that all the modules have idled and
>> asserted
>>>> idleack when Core is entering off state?
>>> Besides these, Core off should reset the modules which are only in
>> Core
>>> domain. It should not impact other power domains. Also Core domain
>>> modules
>>> which are reset will restore their context when Core comes out of
>> off
>>> mode. So why are you saying that "If those parts of the chip are
>> busy,
>>> the reset will disrupt them, causing unpredictable and generally
>>> undesirable results."?
>>
>> Core off issues reset to peripheral domains when it wakes up, this
>> is somehow (badly) visible in TRM (look for COREDOMAINWKUP_RST.)
>> When this reset happens, the peripheral domain shows its reset
>> status as being high, but the powerdomain itself has not entered off
>> (previous state can be e.g. RET), thus its context will not be
>> restored.
That's for that reason that CORE OFF with any other power domain active
is not a supported configuration from the system point of view.
And for that very same reason it was removed on OMAP4 to avoid the OMAP3
confusion. Only CORE OSWR is supported on OMAP4.
CORE OFF should be set only if device OFF is targeted, all the other
combinations are not valid.
Wakeup from CORE off will force a reset in order to ensure that the MPU
and thus the ROM code is executed in order to deal with firewall config.
Regards,
Benoit
next prev parent reply other threads:[~2011-01-19 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 9:48 [PATCH] OMAP3: CPUIdle: prevent CORE from going off if doing so would reset an active clockdomain Tero Kristo
2011-01-18 21:52 ` Paul Walmsley
2011-01-19 4:39 ` Vishwanath Sripathy
2011-01-19 6:05 ` Vishwanath Sripathy
2011-01-19 8:38 ` Tero.Kristo
2011-01-19 9:03 ` Santosh Shilimkar
2011-01-19 20:25 ` Cousson, Benoit [this message]
2011-01-21 9:22 ` Tero.Kristo
2011-01-19 8:22 ` Tero.Kristo
2011-01-19 8:33 ` Santosh Shilimkar
2011-01-19 10:07 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3748A5.4020207@ti.com \
--to=b-cousson@ti.com \
--cc=Tero.Kristo@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.