From: Hannes Reinecke <hare@suse.de>
To: Mike Snitzer <snitzer@redhat.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, Martin George <marting@netapp.com>
Subject: Re: [PATCH] [SCSI] scsi_dh_alua: fix overflow in alua_rtpg port group id check
Date: Thu, 20 Jan 2011 08:24:45 +0100 [thread overview]
Message-ID: <4D37E33D.3090901@suse.de> (raw)
In-Reply-To: <1295399511-10894-1-git-send-email-snitzer@redhat.com>
On 01/19/2011 02:11 AM, Mike Snitzer wrote:
> For Target Portal Group IDs occupying the full 2 bytes in the RTPG
> response, the following group_id check in alua_rtpg() always fails
> because 'ucp' is only a signed char:
> if (h->group_id == (ucp[2] << 8) + ucp[3]) {
>
> Fix this signed char overflow by changing 'ucp' to an unsigned char
> pointer (same type used for 'buff' member of alua_dh_data structure).
>
> Reported-by: Martin George <marting@netapp.com>
> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-20 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 1:11 [PATCH] [SCSI] scsi_dh_alua: fix overflow in alua_rtpg port group id check Mike Snitzer
2011-01-20 7:24 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D37E33D.3090901@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=marting@netapp.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.