All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/4] atmodem: sim-auth atom driver.
Date: Thu, 20 Jan 2011 11:30:02 -0600	[thread overview]
Message-ID: <4D38711A.6040608@gmail.com> (raw)
In-Reply-To: <B668883EB5DD7144ADFC248A72176EA802DA0746@fioues07.ebgroup.elektrobit.com>

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

Hi Jeevaka,

>> +	buffer = g_malloc(len);
> 
> missing check for buffer memory allocation failure 
> 

Actually he's using g_malloc, so the application will simply abort.

>> +	sad = g_new0(struct sim_auth_data, 1);
> 
> missing check for "sad" memory allocation failure 

Same here.

My view is that checking mallocs of small structures is pretty much
pointless on Linux.

Regards,
-Denis

  reply	other threads:[~2011-01-20 17:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19  8:07 [PATCH 1/4] Remove initialisers for enum ofono_atom_type Andrzej Zaborowski
2011-01-19  8:07 ` [PATCH 1/2] simutil: SIM applications directory decoding utils Andrzej Zaborowski
2011-01-20 17:24   ` Denis Kenzior
2011-01-19  8:07 ` [PATCH 2/2] unit: Add a test for applications directory decoding utility Andrzej Zaborowski
2011-01-20 17:24   ` Denis Kenzior
2011-01-19  8:07 ` [PATCH 2/4] Add SIM authentication atom's driver definitions Andrzej Zaborowski
2011-01-20 17:24   ` Denis Kenzior
2011-01-19  8:07 ` [PATCH 3/4] Add the sim-auth atom Andrzej Zaborowski
2011-01-20 17:25   ` Denis Kenzior
2011-01-19  8:07 ` [PATCH 4/4] atmodem: sim-auth atom driver Andrzej Zaborowski
2011-01-20 16:21   ` Jeevaka.Badrappan
2011-01-20 17:30     ` Denis Kenzior [this message]
2011-01-21 17:07       ` Pekka Pessi
2011-01-21 17:25         ` Denis Kenzior
2011-01-20 17:25   ` Denis Kenzior
2011-01-20 17:23 ` [PATCH 1/4] Remove initialisers for enum ofono_atom_type Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D38711A.6040608@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.