Re: [PATCH 3/3] Fix the wrong corrupted page information of hugetlb page.

[Jin Dongming <jin.dongming@np.css.fujitsu.com>]

Hi, Naoya-san

(2011/01/21 14:12), Naoya Horiguchi wrote:
> Hi,
> 
>> @@ -991,18 +995,32 @@ int __memory_failure(unsigned long pfn, int trapno, int flags)
>>  			action_result(pfn, "free buddy", DELAYED);
>>  			return 0;
>>  		} else if (PageHuge(hpage)) {
>> -			/*
>> -			 * Check "just unpoisoned", "filter hit", and
>> -			 * "race with other subpage."
>> -			 */
>>  			lock_page_nosync(hpage);
>> -			if (!PageHWPoison(p)
>> -			    || (hwpoison_filter(p) && TestClearPageHWPoison(p))
>> -			    || (p != hpage && TestSetPageHWPoison(hpage))) {
>> -				atomic_long_sub(nr_pages, &mce_bad_pages);
>> +			/* Check "just unpoisoned". */
>> +			if (!PageHWPoison(hpage)) {
>                                           ^^^^^
> Isn't this "p" (as you changed in patch 2/3) ?
Yes, you are right.
I will send a new one as soon as possible.

Thanks.

Best Regards,
Jin Dongming
> 
> -- Naoya Horiguchi
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
>