From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38436 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PgFo2-0006Jj-L2 for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:09:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PgFo0-0002v9-5c for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:09:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PgFnz-0002uq-Ts for qemu-devel@nongnu.org; Fri, 21 Jan 2011 07:09:28 -0500 Message-ID: <4D3977CE.6030403@redhat.com> Date: Fri, 21 Jan 2011 13:10:54 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1295610150-49752-1-git-send-email-Pierre.Riteau@irisa.fr> In-Reply-To: <1295610150-49752-1-git-send-email-Pierre.Riteau@irisa.fr> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2] Fix block migration when the device size is not a multiple of 1 MB List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pierre Riteau Cc: qemu-devel@nongnu.org, tamura.yoshiaki@lab.ntt.co.jp Am 21.01.2011 12:42, schrieb Pierre Riteau: > b02bea3a85cc939f09aa674a3f1e4f36d418c007 added a check on the return > value of bdrv_write and aborts migration when it fails. However, if the > size of the block device to migrate is not a multiple of BLOCK_SIZE > (currently 1 MB), the last bdrv_write will fail with -EIO. > > Fixed by calling bdrv_write with the correct size of the last block. > > Signed-off-by: Pierre Riteau Thanks, applied to the block branch. Kevin