[PATCH]: xl: catch invalid numeric domain ID

[Andre Przywara <andre.przywara@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi,

if you run any domain specific xl command with an invalid (aka 
non-existing) numeric domain ID, the command does not abort, but 
proceeds with some bogus number:
# xl destroy 42
libxl: error: libxl.c:692:libxl_domain_destroy xc_domain_pause failed for 42
libxl: error: libxl_dm.c:705:libxl__destroy_device_model Couldn't find 
device model's pid: No such file or directory
libxl: error: libxl.c:696:libxl_domain_destroy 
libxl__destroy_device_model failed for 42
libxl: error: libxl_device.c:325:libxl__devices_destroy 
/local/domain/42/device is empty
libxl: error: libxl_dom.c:536:userdata_path unable to find domain info 
for domain 42: Success
libxl: error: libxl.c:713:libxl_domain_destroy xc_domain_destroy failed 
for 42

The attached patch catches a non-existing domain and returns early (as 
an invalid domain _name_ would do).
Please apply to Xen 4.1.0-rc.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany

[-- Attachment #2: xl_fix_invalid_numeric_id.patch --]
[-- Type: text/plain, Size: 440 bytes --]

diff -r 003acf02d416 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Thu Jan 20 17:04:06 2011 +0000
+++ b/tools/libxl/xl_cmdimpl.c	Fri Jan 21 17:11:10 2011 +0100
@@ -170,6 +170,10 @@
         exit(2);
     }
     common_domname = was_name ? p : libxl_domid_to_name(&ctx, domid);
+    if (common_domname == NULL) {
+    	fprintf(stderr, "%d is not a valid domain\n", domid);
+    	exit(2);
+    }
 }
 
 static int acquire_lock(void)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel