Re: [PATCH] cifs: Replace cifs md5 hashing functions with kernel crypto APIs

["Stefan (metze) Metzmacher" <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]

Hi Shirish,

>>> From: Shirish Pargaonkar <shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>
>>> Replace remaining use of md5 hash functions local to cifs module
>>> with kernel crypto APIs.
>>> Remove header and source file containing those local functions.
>>>
>>>
>>> Signed-off-by: Shirish Pargaonkar <shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>>  fs/cifs/Makefile      |    2 +-
>>>  fs/cifs/cifsencrypt.c |    1 -
>>>  fs/cifs/link.c        |   59 +++++++--
>>>  fs/cifs/md5.c         |  366 -------------------------------------------------
>>>  fs/cifs/md5.h         |   38 -----
>>>  fs/cifs/smbencrypt.c  |    1 -
>>>  6 files changed, 51 insertions(+), 416 deletions(-)
>>>  delete mode 100644 fs/cifs/md5.c
>>>  delete mode 100644 fs/cifs/md5.h
>>>
>>
>> Very nice. The CIFS parts look good to me, and I'm always fond of
>> reducing the code we need to support as well as the cifs.ko footprint.
>> Assuming that mfsymlink support still works after this patch...
> 
> I did test briefly, e.g. creating symlinks and deleting them.
> Hoping Stefan Metzmacher will comment.
> I did verify that the (md5) hash value was different for different actualpaths

Just test with and without your changes, create symlinks with both
versions which point to
the same target. And verify you can use them with both.
Then you can mount without mfsymlink support and verify that the
lowlevel file
has the same md5sum.

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]