All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.r.fastabend@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
	"jarkao2@gmail.com" <jarkao2@gmail.com>,
	"hadi@cyberus.ca" <hadi@cyberus.ca>,
	"shemminger@vyatta.com" <shemminger@vyatta.com>,
	"tgraf@infradead.org" <tgraf@infradead.org>,
	"nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] net: netif_setup_tc() is static
Date: Fri, 21 Jan 2011 09:54:53 -0800	[thread overview]
Message-ID: <4D39C86D.2060209@intel.com> (raw)
In-Reply-To: <1295587088.2613.51.camel@edumazet-laptop>

On 1/20/2011 9:18 PM, Eric Dumazet wrote:
> Le mercredi 19 janvier 2011 à 23:41 -0800, David Miller a écrit :
>> From: John Fastabend <john.r.fastabend@intel.com>
>> Date: Mon, 17 Jan 2011 10:06:04 -0800
>>
>>> This patch provides a mechanism for lower layer devices to
>>> steer traffic using skb->priority to tx queues.
>>  ...
>>> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
>>
>> Applied.
> 
> Hi John
> 
> Should netif_setup_tc() be static, or is it meant to be exported
> somehow ?
> 
> [PATCH net-next-2.6] net: netif_setup_tc() is static
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> ---

Acked-by: John Fastabend <john.r.fastabend@intel.com>

Yes this should be static. Thanks Eric!


  reply	other threads:[~2011-01-21 17:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 18:05 [net-next-2.6 PATCH v8 0/2] Series short description John Fastabend
2011-01-17 18:06 ` [net-next-2.6 PATCH v8 1/2] net: implement mechanism for HW based QOS John Fastabend
2011-01-20  7:41   ` David Miller
2011-01-21  5:18     ` [PATCH net-next-2.6] net: netif_setup_tc() is static Eric Dumazet
2011-01-21 17:54       ` John Fastabend [this message]
2011-01-21 21:08         ` David Miller
2011-01-17 18:06 ` [net-next-2.6 PATCH v8 2/2] net_sched: implement a root container qdisc sch_mqprio John Fastabend
2011-01-20  7:41   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D39C86D.2060209@intel.com \
    --to=john.r.fastabend@intel.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hadi@cyberus.ca \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=shemminger@vyatta.com \
    --cc=tgraf@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.