From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue
Date: Fri, 21 Jan 2011 14:10:08 -0600 [thread overview]
Message-ID: <4D39E820.7060802@gmail.com> (raw)
In-Reply-To: <FC2FB65B4D919844ADE4BE3C2BB739AD34F6CD39@shsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Hi Martin,
>> You still forgot to apply my earlier comment. The recv ACCM should be
>> set to what is acked by the peer. e.g.:
> That is not this patch want to resolve. This patch is just used to fix the mixing up of setting recv ACCM and transit ACCM, And fix Huawei modem issue.
>
> 1. Currently, it is just ACKed by peer. You know It is called at lcp_rca, and here the code always use ACCM as 0x0. So that is just the acked ACCM.
Then please send a 2nd patch that just sets the recv ACCM to the one
acked by the peer if you want to be pedantic. But changing the chunk
once, then changing it in the second chunk to some other value will only
serve to confuse me or anyone who reviews your patch submissions.
Regards,
-Denis
prev parent reply other threads:[~2011-01-21 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 5:45 [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue martin.xu
2011-01-20 5:45 ` [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package martin.xu
2011-01-20 5:45 ` [PATCH 3/3] Huawei: set Huawei EM770W modem device to 00 martin.xu
2011-01-20 18:22 ` Lucas De Marchi
2011-01-20 19:10 ` [PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package Denis Kenzior
2011-01-21 1:51 ` Xu, Martin
2011-01-21 20:07 ` Denis Kenzior
2011-01-20 19:08 ` [PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue Denis Kenzior
2011-01-21 2:09 ` Xu, Martin
2011-01-21 20:10 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D39E820.7060802@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.