All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Michelsen <lm@larsmichelsen.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Added Europe/Berlin timezone to tzdata pkg
Date: Fri, 21 Jan 2011 21:30:30 +0100	[thread overview]
Message-ID: <4D39ECE6.4030904@larsmichelsen.com> (raw)
In-Reply-To: <1295178455.5847.36.camel@mattotaupa>

Hello Paul,

On 16/01/11 12:47, Paul Menzel wrote:
> Dear Lars,
>
>
> Am Sonntag, den 16.01.2011, 01:45 +0100 schrieb Lars Michelsen:
>> I was missing the Europe/Berlin timezone in the tzdata package. So I
>> added it to the package.
>>
>> Additionally increased the PR. Hope this OK for such a change - must
>> admit that I am very new to OE.
>
> thank you very much for your patch and welcome to OE.
>
> Could you please resend your patch (`[PATCH v2]`) with the following two
> points addressed.
>
> 1. The commit summary is standardized and should start with the package
> name as documented in the commit policy [1].
>
> 	tzdata: package `Europe/Berlin` timezone
>
> 2. Although it probably does not matter, commit messages are normally
> written from a neutral view point(?) and personal comments are added
> after a `---` before the diff which starts also with `---`. When
> applying your patch, these remarks are left out then.

Thanks for the information. I'll do so on my next postings.

But after the post of Koen I am unsure if I should resubmit this patch. 
My intend was to fix my time, setting the TZ to Europe/Paris fixes this 
and is absolutely ok for me. Other thoughts?

Regards,
Lars



  reply	other threads:[~2011-01-21 20:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-16  0:45 [PATCH] Added Europe/Berlin timezone to tzdata pkg Lars Michelsen
2011-01-16 11:47 ` Paul Menzel
2011-01-21 20:30   ` Lars Michelsen [this message]
2011-01-16 12:04 ` Koen Kooi
2011-01-21 20:32   ` Lars Michelsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D39ECE6.4030904@larsmichelsen.com \
    --to=lm@larsmichelsen.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.