From: "H. Peter Anvin" <hpa@zytor.com>
To: matthieu castet <castet.matthieu@free.fr>
Cc: Lin Ming <ming.m.lin@intel.com>, Oliver Neukum <oneukum@suse.de>,
rjw@sisk.pl, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Denys Vlasenko <vda.linux@googlemail.com>,
Michal Marek <mmarek@suse.cz>, Yinghai Lu <yinghai@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Borislav Petkov <bp@alien8.de>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Siarhei Liakh <sliakh.lkml@gmail.com>,
Xuxian Jiang <jiang@cs.ncsu.edu>,
Dave Airlie <airlied@redhat.com>, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [REGRESSION] S3 resume on SandyBridge doesn't work with NX protection (5bd5a45)
Date: Fri, 21 Jan 2011 14:30:12 -0800 [thread overview]
Message-ID: <4D3A08F4.1050706@zytor.com> (raw)
In-Reply-To: <4D3A05DC.4000208@free.fr>
On 01/21/2011 02:17 PM, matthieu castet wrote:
> Of course, but for example on x64, using smp trampoline to exit rm wakecode help
> to merge code in one place.
Yes, and there are numerous cleanups like that that can be done.
> Also the start of 32/64 bits trampoline (rm part) is really similar. The main difference is the verify_cpu
> check, but can't it be called latter (when we switch to 64 bits ) ?
One can *sometimes* do merges like that, but one has to be careful to
not make the code more complex instead of less by mistake. Minor code
duplication is better than really ugly code.
-hpa
next prev parent reply other threads:[~2011-01-21 22:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 17:37 [REGRESSION] S3 resume on SandyBridge doesn't work with NX protection (5bd5a45) Matthias Hopf
2011-01-19 19:04 ` H. Peter Anvin
2011-01-19 22:06 ` matthieu castet
2011-01-20 13:47 ` Matthias Hopf
[not found] ` <1295535954.4d384f524c8f0@imp.free.fr>
2011-01-20 15:59 ` Matthias Hopf
[not found] ` <4D38A697.3040308@free.fr>
2011-01-20 21:25 ` H. Peter Anvin
2011-01-21 22:17 ` matthieu castet
2011-01-21 22:30 ` H. Peter Anvin [this message]
2011-01-25 14:07 ` castet.matthieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3A08F4.1050706@zytor.com \
--to=hpa@zytor.com \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=castet.matthieu@free.fr \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=fweisbec@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jiang@cs.ncsu.edu \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=oneukum@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sliakh.lkml@gmail.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vda.linux@googlemail.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.