From: John Fastabend <john.r.fastabend@intel.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"shmulikr@broadcom.com" <shmulikr@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [net-2.6 PATCH 1/2] net: dcbnl: remove redundant DCB_CAP_DCBX_STATIC bit
Date: Fri, 21 Jan 2011 18:52:15 -0800 [thread overview]
Message-ID: <4D3A465F.8020809@intel.com> (raw)
In-Reply-To: <20110122023512.4239.40379.stgit@jf-dev1-dcblab>
On 1/21/2011 6:35 PM, John Fastabend wrote:
> Remove redundant DCB_CAP_DCBX_STATIC bit in DCB capabilities
>
> Setting this bit indicates that no embedded DCBx engine is
> present and the hardware can not be configured. This is the
> same as having none of the DCB capability flags set or simply
> not implementing the dcbnl ops at all.
>
> This patch removes this bit. The bit has not made a stable
> release yet so removing it should not be an issue with
> existing apps.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
> CC: Shmulik Ravid <shmulikr@broadcom.com>
> ---
>
Shmulik, could you ACK this because you added these bits? But
I was adding support for this in lldpad and I see no reason that
we need these?
Thanks,
John.
next prev parent reply other threads:[~2011-01-22 2:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-22 2:35 [net-2.6 PATCH 1/2] net: dcbnl: remove redundant DCB_CAP_DCBX_STATIC bit John Fastabend
2011-01-22 2:35 ` [net-2.6 PATCH 2/2] dcbnl: make get_app handling symmetric for IEEE and CEE DCBx John Fastabend
2011-01-24 23:20 ` David Miller
2011-01-22 2:52 ` John Fastabend [this message]
2011-01-23 16:53 ` [net-2.6 PATCH 1/2] net: dcbnl: remove redundant DCB_CAP_DCBX_STATIC bit Shmulik Ravid
2011-01-24 5:46 ` John Fastabend
2011-01-24 15:27 ` Shmulik Ravid
2011-01-24 15:52 ` John Fastabend
2011-01-24 23:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3A465F.8020809@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shmulikr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.