All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlie <airlied@linux.ie>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix use of invalid array size for ring->sync_seqno
Date: Sat, 22 Jan 2011 23:24:21 +0100	[thread overview]
Message-ID: <4D3B5915.7060206@gmail.com> (raw)
In-Reply-To: <1295604715-24563-1-git-send-email-chris@chris-wilson.co.uk>

On 01/21/2011 11:11 AM, Chris Wilson wrote:
> There are I915_NUM_RINGS-1 inter-ring synchronisation counters, but we
> were clearing I915_NUM_RINGS of them. Oops.
> 
> Reported-by: Jiri Slaby <jirislaby@gmail.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> 
> Jiri, does this catch the invalid array access? For 3 rings, there should
> only be 2 sync counters...

Yup, it's gone.

thanks,
--
js

      reply	other threads:[~2011-01-22 22:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20  2:39 more intel drm issues (was Re: [git pull] drm intel only fixes) Linus Torvalds
2011-01-20  2:39 ` Linus Torvalds
2011-01-20  4:55 ` Jeff Chua
2011-01-20  6:22   ` Linus Torvalds
2011-01-20  6:22     ` Linus Torvalds
2011-01-20 10:17     ` Jeff Chua
2011-01-20 10:25     ` Chris Wilson
2011-01-20 16:07       ` Linus Torvalds
2011-01-20 17:38         ` Chris Wilson
2011-01-20 17:51           ` Linus Torvalds
2011-01-20 20:44             ` Linus Torvalds
2011-01-20 17:41         ` [PATCH] drm/i915/ringbuffer: Fix use of stale HEAD position whilst polling for space Chris Wilson
2011-01-20 17:41           ` Chris Wilson
2011-01-21  8:35           ` Jiri Slaby
2011-01-21 10:11             ` [PATCH] drm/i915: Fix use of invalid array size for ring->sync_seqno Chris Wilson
2011-01-21 10:11               ` Chris Wilson
2011-01-22 22:24               ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3B5915.7060206@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.