From: Anthony Liguori <anthony@codemonkey.ws>
To: Chunqiang Tang <ctang@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver
Date: Sun, 23 Jan 2011 17:26:04 -0600 [thread overview]
Message-ID: <4D3CB90C.8020702@codemonkey.ws> (raw)
In-Reply-To: <OFD60FB7DB.A56C3EBE-ON85257820.001120A2-85257820.0011375A@us.ibm.com>
On 01/21/2011 09:09 PM, Chunqiang Tang wrote:
>> Coding style.
>>
>> In general, I like the idea of the simulator but the coding style is off
>>
>
>> quite a bit.
>>
> Please be specific and I would be happy to take suggestions. The header
> issue should be easy to fix.
>
Read CODING_STYLE and go through your code.
The code pretty consistently doesn't follow it.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-01-23 23:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 22:19 [Qemu-devel] [PATCH 1/3] FVD: Added support for 'qemu-img update' Chunqiang Tang
2011-01-21 22:19 ` [Qemu-devel] [PATCH 2/3] FVD: Added the simulated 'blksim' driver Chunqiang Tang
2011-01-21 22:49 ` Anthony Liguori
2011-01-22 3:09 ` Chunqiang Tang
2011-01-23 23:26 ` Anthony Liguori [this message]
2011-01-24 15:07 ` Chunqiang Tang
2011-01-23 15:26 ` Andreas Färber
2011-01-25 16:54 ` Chunqiang Tang
2011-01-21 22:19 ` [Qemu-devel] [PATCH 3/3] FVD: Made qemu-io working with simulation (blksim) Chunqiang Tang
2011-01-28 9:57 ` [Qemu-devel] [PATCH 1/3] FVD: Added support for 'qemu-img update' Stefan Hajnoczi
2011-01-28 14:51 ` Chunqiang Tang
2011-01-28 16:16 ` Stefan Hajnoczi
2011-01-28 21:26 ` Chunqiang Tang
2011-01-29 10:05 ` Stefan Hajnoczi
2011-01-31 14:49 ` Chunqiang Tang
2011-02-01 13:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3CB90C.8020702@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=ctang@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.