From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47306 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PhJcD-0004jP-6n
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:25:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PhJb3-0003Rb-S3
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:24:30 -0500
Received: from mel.act-europe.fr ([194.98.77.210]:35689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1PhJb3-0003Pp-MB
	for qemu-devel@nongnu.org; Mon, 24 Jan 2011 05:24:29 -0500
Message-ID: <4D3D5346.6070805@adacore.com>
Date: Mon, 24 Jan 2011 11:24:06 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 0/5][RFC] New SPARC machine: Leon3
References: <cover.1295628148.git.chouteau@adacore.com>
	<AANLkTi=rqOQvb2qCM7YaTQ4qVUjq1vJ5mBJUTLwQBFH5@mail.gmail.com>
In-Reply-To: <AANLkTi=rqOQvb2qCM7YaTQ4qVUjq1vJ5mBJUTLwQBFH5@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org

On 01/21/2011 08:04 PM, Blue Swirl wrote:
> On Fri, Jan 21, 2011 at 5:00 PM, Fabien Chouteau<chouteau@adacore.com>  wrote:
>> Hello Qemu-devel,
>>
>> Here is the third version of Leon3 emulation patch-set.
>>
>> Modifications since v2:
>>   - Tracepoints
>>   - DEFINE_PROP_* macros
>>   - New interface to trigger interrupts on Leon3 (set_pil_in:leon3.c)
>>   - Minor reformating
>>
>> Please feel free to comment.
>
> The patches look fine to me now, except 4/5 had a small problem.
>
> Could you run them through checkpatch.pl and fix the issues? The lines
> like //#define DEBUG_LEON3 can stay despite the error if you don't
> convert them to tracepoints.

Sure, I will fix the two problems that you pointed out and run checkpatch.pl
to fix the remaining style issues.

-- 
Fabien Chouteau