All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, "Justin M. Forbes" <jforbes@redhat.com>,
	Christoph Hellwig <hch@lst.de>
Subject: [Qemu-devel] Re: [PATCH v4 0/4] usb-msd: Add usb-storage, removable=on|off property
Date: Mon, 24 Jan 2011 16:55:35 +0100	[thread overview]
Message-ID: <4D3DA0F7.1000104@redhat.com> (raw)
In-Reply-To: <1295883301-7278-1-git-send-email-stefanha@linux.vnet.ibm.com>

Am 24.01.2011 16:34, schrieb Stefan Hajnoczi:
> Allow overriding the SCSI INQUIRY removable (RMB) bit for scsi-disk and usb-msd
> devices.  In particular this addresses the problem that some usb-msd devices
> have the bit set while other do not have it set.  Now the user can choose and
> get desired guest behavior.
> 
> qemu -usb
>     -drive if=none,file=test.img,cache=none,id=disk0
>     -device usb-storage,drive=disk0,removable=on
> 
> The default is off.
> 
> v4:
>  * Explicitly state that scsi-generic does not support the removable bit override
>  * Try to make the scsi_bus_legacy_add_drive() commit description clearer
> 
> v3:
>  * Document removable property in qdev-device-use.txt
>  * Use bit number 0 instead of bit 1 for the qdev property
> 
> v2:
>  * Rewritten to override the bit at the scsi-disk level
> 

Thanks, updated the patches in the block branch.

Kevin

      parent reply	other threads:[~2011-01-24 15:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 15:34 [Qemu-devel] [PATCH v4 0/4] usb-msd: Add usb-storage, removable=on|off property Stefan Hajnoczi
2011-01-24 15:34 ` [Qemu-devel] [PATCH v4 1/4] scsi-disk: Allow overriding SCSI INQUIRY removable bit Stefan Hajnoczi
2011-01-24 15:34 ` [Qemu-devel] [PATCH v4 2/4] scsi: Allow scsi_bus_legacy_add_drive() to set " Stefan Hajnoczi
2011-01-24 15:35 ` [Qemu-devel] [PATCH v4 3/4] usb-msd: Propagate removable bit to SCSI device Stefan Hajnoczi
2011-01-24 15:35 ` [Qemu-devel] [PATCH v4 4/4] docs: Document scsi-disk and usb-storage removable parameter Stefan Hajnoczi
2011-01-24 15:55 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3DA0F7.1000104@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=hch@lst.de \
    --cc=jforbes@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.