All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Chifflier <chifflier@wzdftpd.net>
To: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: ebtables_nfqueue: missing structure afinfo
Date: Mon, 24 Jan 2011 21:55:18 +0100	[thread overview]
Message-ID: <4D3DE736.70808@wzdftpd.net> (raw)

Hi,

I'm still working on a module to add the NFQUEUE target to ebtables.

So far, I've been able to split the work on two parts: sending the
packets to nfqueue, and re-inject them after a verdict. I'll split
questions on separate emails.

Adding the NFQUEUE target is not a difficult task (making the
ebt_do_tables return NF_QUEUE_NR(queue_num)), however this won't work
since the __nf_queue() function [1] requires an afinfo structure :
132         afinfo = nf_get_afinfo(pf);
133         if (!afinfo)
134                 goto err_unlock;

Since there is no afinfo structure for AF_BRIDGE, this won't work.

I tried adding a dummy (empty) afinfo structure and registering it in
ebtables_init(), but that does not look like a clean solution ...

What would be the best way (in order to be proposed mainstream) to do
that ? The afinfo structure seems to be called to save the route (and
then restored when re-injecting), I'm not sure yet if this is necessary
for AF_BRIDGE packets.

Thanks,
Pierre

[1]
http://www.cs.fsu.edu/~baker/devices/lxr/http/source/linux/net/netfilter/nf_queue.c#L108

             reply	other threads:[~2011-01-24 21:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 20:55 Pierre Chifflier [this message]
2011-01-25 10:34 ` ebtables_nfqueue: missing structure afinfo Patrick McHardy
2011-02-02 19:22   ` Pierre Chifflier
2011-02-02 22:59     ` Patrick McHardy
2011-02-03 14:32       ` WIP/RFC: add new module ebt_NFQUEUE for ebtables Pierre Chifflier
2011-02-03 20:19         ` Bart De Schuymer
2011-02-04 10:05         ` Pierre Chifflier
2011-02-04 13:07           ` Patrick McHardy
2011-02-04 13:20             ` Pierre Chifflier
2011-02-04 13:21               ` Patrick McHardy
2011-02-03 14:32       ` [PATCH 1/3] Make the afinfo structure optional in nf_queue and nf_reinject Pierre Chifflier
2011-02-04 13:27         ` Patrick McHardy
2011-02-04 14:15           ` Pierre Chifflier
2011-02-03 14:32       ` [PATCH 2/3] bridge: add support for the EBT_QUEUE target Pierre Chifflier
2011-02-03 14:32       ` [PATCH 3/3] bridge: add new target NFQUEUE for ebtables Pierre Chifflier
2011-02-04 13:25         ` Patrick McHardy
2011-02-04 13:40           ` Pierre Chifflier
2011-02-04 13:41             ` Patrick McHardy
     [not found]               ` <4D5104C4.3010105@edenwall.com>
     [not found]                 ` <4D59C047.5050404@trash.net>
2011-02-16 16:57                   ` [RFH] " Pierre Chifflier
2011-02-17 10:47                     ` Patrick McHardy
2011-02-17 13:37                       ` Pierre Chifflier
2011-02-18 13:42                         ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3DE736.70808@wzdftpd.net \
    --to=chifflier@wzdftpd.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.