[Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

[Anthony Liguori <aliguori@linux.vnet.ibm.com>]

On 01/24/2011 03:00 PM, Anthony Liguori wrote:
> Leave the disable options for now to help with testing but these will be removed
> once we're confident in the thread implementations.
>
> Disabled code bit rots.  These have been in tree long enough that we need to
> either commit to making them work or just remove them entirely.
>    

I/O thread disables icount apparently.

I'm not really sure why.  Marcelo, do you know the reason 
qemu_calculate_timeout returns a fixed value in the I/O thread 
regardless of icount?

Regards,

Anthony Liguori

> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> diff --git a/configure b/configure
> index d68f862..d5ac074 100755
> --- a/configure
> +++ b/configure
> @@ -124,7 +124,7 @@ vnc_tls=""
>   vnc_sasl=""
>   vnc_jpeg=""
>   vnc_png=""
> -vnc_thread="no"
> +vnc_thread="yes"
>   xen=""
>   linux_aio=""
>   attr=""
> @@ -161,7 +161,7 @@ darwin_user="no"
>   bsd_user="no"
>   guest_base=""
>   uname_release=""
> -io_thread="no"
> +io_thread="yes"
>   mixemu="no"
>   kerneldir=""
>   aix="no"
> @@ -699,6 +699,8 @@ for opt do
>     ;;
>     --enable-io-thread) io_thread="yes"
>     ;;
> +  --disable-io-thread) io_thread="no"
> +  ;;
>     --disable-blobs) blobs="no"
>     ;;
>     --kerneldir=*) kerneldir="$optarg"
> @@ -901,6 +903,7 @@ echo "  --enable-linux-aio       enable Linux AIO support"
>   echo "  --disable-attr           disables attr and xattr support"
>   echo "  --enable-attr            enable attr and xattr support"
>   echo "  --enable-io-thread       enable IO thread"
> +echo "  --disable-io-thread      disable IO thread"
>   echo "  --disable-blobs          disable installing provided firmware blobs"
>   echo "  --kerneldir=PATH         look for kernel includes in PATH"
>   echo "  --enable-docs            enable documentation build"
>