All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benny Halevy <bhalevy@panasas.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Thomas Haynes <thomas@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: Patched up cthon source?
Date: Mon, 24 Jan 2011 17:33:36 -0500	[thread overview]
Message-ID: <4D3DFE40.1070605@panasas.com> (raw)
In-Reply-To: <83EC814B-1043-46B2-8F5E-E1FB1F5B56BF@oracle.com>

On 2011-01-24 17:24, Chuck Lever wrote:
> 
> On Jan 24, 2011, at 5:19 PM, Thomas Haynes wrote:
> 
>> I'm being evil here on purpose. :->
>>
>> I'm trying to run cthon04 as downloaded from the connectathon.org repository
>> and I'm getting this:
>>
>>
>> Nroff
>> ./stat: no data in nroff.time
>> general tests failed
>> Tests failed, leaving /cthon04/loghyr mounted
>>
>>
>> As I kinda recall several people fixing this already, where would I go to get patches?
> 
> What are your CFLAGS settings in tests.init?
> 

this is a problem with the version of nroff on newer distributions.
The following patch fixed it for me last bakeathon:

>From f44b150809e43b129fad34e3e4ec288e4dd36e6c Mon Sep 17 00:00:00 2001
From: Benny Halevy <bhalevy@panasas.com>
Date: Wed, 6 Oct 2010 11:37:27 -0400
Subject: [PATCH] cthon nroff general test workaround

Newer versions of nroff spew out a warning that cause the cthon test
to fail in the following way:

Nroff
./stat: no data in nroff.time
general tests failed

The following patch filters out the warning from the output file
generated during the test.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
---
 general/runtests.wrk |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/general/runtests.wrk b/general/runtests.wrk
index f3a5a4e..8247e2f 100644
--- a/general/runtests.wrk
+++ b/general/runtests.wrk
@@ -89,6 +89,8 @@ $TIME nroff < nroff.tbl > nroff.out 2>> nroff.time || cat nroff.time
 $TIME nroff < nroff.tbl > nroff.out 2>> nroff.time || cat nroff.time
 rm nroff.out nroff.tbl
 set -e
+egrep -v '^warning:.*$' <nroff.time >nroff.new
+mv -f nroff.new nroff.time
 ./stat nroff.time
 set +e
 
-- 
1.7.3.4


  reply	other threads:[~2011-01-24 22:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 22:19 Patched up cthon source? Thomas Haynes
2011-01-24 22:24 ` Chuck Lever
2011-01-24 22:33   ` Benny Halevy [this message]
2011-01-24 23:01     ` Jim Rees
2011-01-24 23:32     ` Thomas Haynes
2011-01-25 13:43     ` Bryan Schumaker
2011-01-25 14:56       ` Jeff Layton
2011-01-25 15:38         ` Trond Myklebust
2011-01-25 15:46           ` peter.staubach
2011-01-25 15:53           ` Jeff Layton
     [not found]         ` <20110125095649.446212fd-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2011-02-07 19:13           ` Jim Rees
2011-02-07 22:00             ` Jeff Layton
2011-01-24 22:50 ` sfaibish
2011-01-25  9:46 ` DENIEL Philippe
2011-01-25 17:05 ` Steve Dickson
2011-01-25 21:36   ` Halevy, Benny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3DFE40.1070605@panasas.com \
    --to=bhalevy@panasas.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=thomas@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.