All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Paged SKBs v/s copybreak.
Date: Mon, 24 Jan 2011 14:33:45 -0800	[thread overview]
Message-ID: <4D3DFE49.7050500@candelatech.com> (raw)

Some time back, I posted a patch to implement rx-copybreak for
ath9k.  There were some other alternative patches that implemented
paged skbs.

My patch had at least one real problem in that it needs to handle
arbitrary busses, not just pci.  Seems that wouldn't be too hard
to implement, but I haven't bothered to date.  It has been stable
for several weeks of testing on various pci-e and pci ath9k NICs.

There was also a worry that for more normal use cases a paged skb
approach might be preferred over the skb-copybreak approach.

I, and a few others, liked pure copybreak because it might work
around DMA start/stop issues in ath9k by ensuring that the hardware
never scribbles on packets handed up the stack.  To me, this is
more important than performance, but then again, I have plenty of
CPU resources available on my systems.

So, I am hoping for some guidance from the core ath9k folks.  Should
I attempt to fix my copybreak patch for non pci busses and re-post
it?

Or should someone fix up the paged skb approach?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

             reply	other threads:[~2011-01-24 22:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 22:33 Ben Greear [this message]
2011-01-24 22:51 ` [ath9k-devel] Paged SKBs v/s copybreak Jouni Malinen
2011-01-24 22:59 ` Felix Fietkau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3DFE49.7050500@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.