Re: [PATCH 6/9] i2c-designware: move controller config to bus specific portion of driver

[Shinya Kuribayashi <shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>]

On 1/15/2011 4:27 AM, dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Dirk Brandewie <dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 
> With multiple I2C adapters possible in the system each running at
> (possibly) different speeds we need to move the controller
> configuration bit field to the adapter.

This is also a good first step to support per-bus basis I2C bus-speed
configuration, because current i2c-designware driver is going to
configure all I2C busses with the same speed settings, unfortunately.

> @@ -375,6 +373,7 @@ int i2c_dw_handle_tx_abort(struct dw_i2c_dev *dev)
>  		return -EIO;
>  }
>  
> +
>  /*
>   * Prepare controller for a transaction and call i2c_dw_xfer_msg
>   */

!

> @@ -212,7 +214,6 @@ const struct pci_device_id *id)
>  
>  	i2c_dw_init(dev);
>  
> -
>  	adap = &dev->adapter;
>  	i2c_set_adapdata(adap, dev);
>  	adap->owner = THIS_MODULE;

!

As talked with Dirk-san before, this patch improves a situation at
PCI driver side only, and we need to come up with a way for platform
side in the future!
-- 
Shinya Kuribayashi
Renesas Electronics