All of lore.kernel.org
 help / color / mirror / Atom feed
From: David C Niemi <dniemi@verisign.com>
To: Vishwanath BS <vishwanath.bs@ti.com>
Cc: cpufreq@vger.kernel.org, patches@linaro.org
Subject: Re: [PATCH] cpufreq: Add documentation for sampling_down_factor
Date: Tue, 25 Jan 2011 09:03:40 -0500	[thread overview]
Message-ID: <4D3ED83C.4030707@verisign.com> (raw)
In-Reply-To: <1295951583-19997-1-git-send-email-vishwanath.bs@ti.com>

Thanks for taking this on.

I wrote this when talking about the patch as a proposed change, now that
it is the status quo, I think the second sentence needs to be adjusted a
bit as follows:

"Set it to 1 it makes no changes from existing behavior," ->
"When set to 1 (the default) decisions to reevaluate load are made at
the same interval regardless of current clock speed;"

DCN

Vishwanath BS wrote:
> Update cpufreq governor documentation for sampling_down_factor tunable
> parameter.
>
> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
> ---
>  Documentation/cpu-freq/governors.txt |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 737988f..ef570ff
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -158,6 +158,16 @@ intensive calculation on your laptop that you do not care how long it
>  takes to complete as you can 'nice' it and prevent it from taking part
>  in the deciding process of whether to increase your CPU frequency.
>  
> +sampling_down_factor: this parameter controls the rate at which the
> +kernel makes a decision on when to decrease the frequency while running
> +at top speed. Set to 1 it makes no changes from existing behavior,
> +but set to greater than 1 (e.g. 100) it acts as a multiplier for the
> +scheduling interval for reevaluating load when the CPU is at its top
> +speed due to high load. This improves performance by reducing the overhead
> +of load evaluation and helping the CPU stay at its top speed when truly
> +busy, rather than shifting back and forth in speed. This tunable has no
> +effect on behavior at lower speeds/lower CPU loads.
> +
>  
>  2.5 Conservative
>  ----------------
>   


      reply	other threads:[~2011-01-25 14:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 10:33 [PATCH] cpufreq: Add documentation for sampling_down_factor Vishwanath BS
2011-01-25 14:03 ` David C Niemi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3ED83C.4030707@verisign.com \
    --to=dniemi@verisign.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=vishwanath.bs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.