From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] gprs-provision: add driver API header
Date: Tue, 25 Jan 2011 14:59:12 -0600 [thread overview]
Message-ID: <4D3F39A0.6080602@gmail.com> (raw)
In-Reply-To: <1295957714-21053-2-git-send-email-jukka.saunamaki@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
Hi Jukka,
> +/* For gprs */
> +void __ofono_gprs_provision_get_settings(const char *mcc, const char *mnc,
> + const char *spn,
> + struct ofono_gprs_provision_data **settings,
> + int *count);
The __ofono prefix implies that this is private ofono API. Things
declared in include/foo.h are public oFono API. Since this does not
seem to be a good candidate for public consumption, can you move this
down to src/ofono.h?
> +void provision_settings_free(struct ofono_gprs_provision_data *settings,
> + int count);
I suggest renaming this to __ofono_gprs_provision_free_settings() and
moving this to src/ofono.h.
Regards,
-Denis
next prev parent reply other threads:[~2011-01-25 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 12:15 [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings Jukka Saunamaki
2011-01-25 12:15 ` [PATCH 1/4] gprs-provision: add driver API header Jukka Saunamaki
2011-01-25 20:59 ` Denis Kenzior [this message]
2011-01-25 12:15 ` [PATCH 2/4] gprs-provision: add driver API sources Jukka Saunamaki
2011-01-25 12:15 ` [PATCH 3/4] gprs: add gprs context provisioning Jukka Saunamaki
2011-01-25 21:08 ` Denis Kenzior
2011-01-25 12:15 ` [PATCH 4/4] gprs-provision: add example context provisioning driver Jukka Saunamaki
2011-01-25 12:28 ` [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings Marcel Holtmann
2011-01-25 12:47 ` Jukka Saunamaki
2011-01-26 9:57 ` Marcel Holtmann
2011-01-26 10:43 ` Aki Niemi
2011-01-26 11:18 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D3F39A0.6080602@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.