All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bian Naimeng <biannm@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/
Date: Wed, 26 Jan 2011 15:07:26 +0800	[thread overview]
Message-ID: <4D3FC82E.707@cn.fujitsu.com> (raw)
In-Reply-To: <AANLkTin52dVdOUf0K25Sma2NrGLmet9aK7tbUmg3fKds@mail.gmail.com>



Garrett Cooper wrote:
> On Tue, Jan 25, 2011 at 10:54 PM, Bian Naimeng <biannm@cn.fujitsu.com> wrote:
>> There is not any directory at testcase/kernel/mem/ksm/,
>> so replace generic_trunk_target.mk by generic_leaf_target.mk
>>
>> Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com>
>>
>> ---
>>  testcases/kernel/mem/ksm/Makefile |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/testcases/kernel/mem/ksm/Makefile b/testcases/kernel/mem/ksm/Makefile
>> index 81509bf..22190f1 100644
>> --- a/testcases/kernel/mem/ksm/Makefile
>> +++ b/testcases/kernel/mem/ksm/Makefile
>> @@ -39,5 +39,5 @@ trunk-clean:: | lib-clean
>>  lib-clean:: $(LIBDIR)
>>        $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
>>
>> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
>>  include $(top_srcdir)/include/mk/testcases.mk
>> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
>     Forgot about that Makefile that Cai submitted. How about this instead?

Looks better than mine. Please commit it.

Thanks
  Bian

> Thanks,
> -Garrett
> 
> diff --git a/testcases/kernel/mem/ksm/Makefile
> b/testcases/kernel/mem/ksm/Makefile
> index 81509bf..fdff5fc 100644
> --- a/testcases/kernel/mem/ksm/Makefile
> +++ b/testcases/kernel/mem/ksm/Makefile
> @@ -18,7 +18,7 @@
> 
>  top_srcdir              ?= ../../../..
> 
> -include $(top_srcdir)/include/mk/env_pre.mk
> +include $(top_srcdir)/include/mk/testcases.mk
> 
>  LDLIBS                 += $(NUMA_LIBS) -lmem
>  LIBDIR                 := ../lib
> @@ -39,5 +39,4 @@ trunk-clean:: | lib-clean
>  lib-clean:: $(LIBDIR)
>         $(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" clean
> 
> -include $(top_srcdir)/include/mk/generic_trunk_target.mk
> -include $(top_srcdir)/include/mk/testcases.mk
> +include $(top_srcdir)/include/mk/generic_leaf_target.mk
> 
> 

-- 
Regards
Bian Naimeng


------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2011-01-26  7:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  6:54 [LTP] [PATCH] Fix Makefile of testcase/kernel/mem/ksm/ Bian Naimeng
2011-01-26  6:58 ` Garrett Cooper
2011-01-26  7:06   ` CAI Qian
2011-01-26  7:07   ` Bian Naimeng [this message]
2011-01-26  7:10     ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3FC82E.707@cn.fujitsu.com \
    --to=biannm@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.